Replace stateIn with DerivedStateFlow in ChannelMutableState (perf im…#5083
Merged
DanielNovak merged 2 commits intodevelopfrom Nov 23, 2023
Merged
Replace stateIn with DerivedStateFlow in ChannelMutableState (perf im…#5083DanielNovak merged 2 commits intodevelopfrom
DanielNovak merged 2 commits intodevelopfrom
Conversation
6a3f856 to
30e3e80
Compare
30e3e80 to
9f8b31f
Compare
aleksandar-apostolov
approved these changes
Nov 23, 2023
This was referenced Nov 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance improvement - this has a measurable impact on cold application start and on loading of new channels, on a Pixel 4a it can save a few percent of the time needed to display the first channels.
Also
stateInwithEagerlyoption creates never ending coroutines which is also not memory or resource effective.We are always combining or mapping just
StateFlows so we can just use aDerivedStateFlowhelper function that will give us back aStateFlow(instead of aFlowlike the normal combine / map functions).