Delay reflection in NotificationHandlerFactory#5078
Merged
DanielNovak merged 2 commits intodevelopfrom Nov 20, 2023
Merged
Conversation
DanielNovak
added
performance
DanielNovak
changed the title
JcMinarro
reviewed
Nov 20, 2023
...in/java/io/getstream/chat/android/client/notifications/handler/NotificationHandlerFactory.kt
Outdated
Show resolved
Hide resolved
JcMinarro
approved these changes
Nov 20, 2023
DanielNovak
force-pushed
the
delay_reflection
branch
from
7fe73a2 to
6cad283
Compare
…roid/client/notifications/handler/NotificationHandlerFactory.kt Co-authored-by: Jc Miñarro <[email protected]>
DanielNovak
force-pushed
the
delay_reflection
branch
from
6cad283 to
3eb77a2
Compare
This was referenced Nov 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delaying the reflection saves ~190ms on the main thread while the SDK is being initialised (usually in the Application.onCreate() - thus delaying the whole application cold start).