Skip to content

feat: new composer#623

Merged
GeopJr merged 121 commits intomainfrom
feat/new-composer
Jul 8, 2025
Merged

feat: new composer#623
GeopJr merged 121 commits intomainfrom
feat/new-composer

Conversation

@GeopJr
Copy link
Owner

@GeopJr GeopJr commented Oct 28, 2023

fix: #553
fix: #973
fix: #472
fix: #1453

@GeopJr
Copy link
Owner Author

GeopJr commented May 29, 2025

The main thing that has been bugging me is the textview. Textview implements scrollable for optimizations. If you move it into a viewport then you lose stuff like scrolling following the cursor. But, we need to have stuff like the label, the replying-to status, the attachment box and the poll box which we can't do easily using its features...

@GeopJr
Copy link
Owner Author

GeopJr commented Jun 12, 2025

Judging by the errors, we are going to have to bump some dependencies, I'll make a last patch release when the current release is ready for the stable distros but that's it. I'm not going to hold back the new composer any longer and all the stuff used are needed.

GeopJr added 6 commits June 13, 2025 10:17
the coditions are a bit messy but this the safest way to avoid race conditions
the delete button is visible if can-delete is true and the row is either not empty or not set to last
in general we would want to communicate with the parents through signals, so we might make the sandwitchview accept an interface that has said signals
atm it only supports scrolling which is needed when we update the poll components and we want the view to scroll to the bottom
an issue with the prior implementation was that the children would be 'cut off' when updating. After a very lengthy debugging process I discovered the issue. The yoffset gets updated after setting the top/bottom margins when we call size_allocate on the textview, but we would only call it between measuring and allocating the top and bottom children, which ended up messing with both. The correct way to do this is: 1. measure top & set top margin, 2. measure bottom & set bottom margin, 3. allocate textview, 4. get the yoffset, 5. allocate the top and bottom widgets as we did prior
@GeopJr GeopJr marked this pull request as ready for review July 8, 2025 09:37
@GeopJr GeopJr merged commit cac5941 into main Jul 8, 2025
5 checks passed
@GeopJr GeopJr deleted the feat/new-composer branch July 8, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Abstract interface [Bug]: Video does not preview in media tab when posting. Composer redesign [Request]: Enhance the media support

3 participants