Merged
Conversation
can cause min width
it can be ellipsized
we have to manually get the first child (toggle button)
1 task
if it's more than 1000 the string is too long to be useful: 1000/1000 let's just keep the remaining part only, it gets the point across as it goes down
Owner
Author
|
The main thing that has been bugging me is the textview. Textview implements scrollable for optimizations. If you move it into a viewport then you lose stuff like scrolling following the cursor. But, we need to have stuff like the label, the replying-to status, the attachment box and the poll box which we can't do easily using its features... |
I need a fix in GTK 19
Owner
Author
|
Judging by the errors, we are going to have to bump some dependencies, I'll make a last patch release when the current release is ready for the stable distros but that's it. I'm not going to hold back the new composer any longer and all the stuff used are needed. |
the coditions are a bit messy but this the safest way to avoid race conditions the delete button is visible if can-delete is true and the row is either not empty or not set to last
in general we would want to communicate with the parents through signals, so we might make the sandwitchview accept an interface that has said signals atm it only supports scrolling which is needed when we update the poll components and we want the view to scroll to the bottom
an issue with the prior implementation was that the children would be 'cut off' when updating. After a very lengthy debugging process I discovered the issue. The yoffset gets updated after setting the top/bottom margins when we call size_allocate on the textview, but we would only call it between measuring and allocating the top and bottom children, which ended up messing with both. The correct way to do this is: 1. measure top & set top margin, 2. measure bottom & set bottom margin, 3. allocate textview, 4. get the yoffset, 5. allocate the top and bottom widgets as we did prior
just clear the target on cleanup
end of an era :')
needed for offset
needs to be done on mapped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #553
fix: #973
fix: #472
fix: #1453