Skip to content

bug(review): RDD pre-delivery preflight's fixed 10 s bound is shorter than native assess on Windows, so every push is denied #3200

Open

Description

@ardelperal

Summary

The RDD pre-delivery guard denies every git push on Windows with "The bounded preflight was cancelled or timed out." The preflight has a fixed 10 s bound (lib/review-delivery-preflight.ts:28, AbortSignal.timeout(10_000)) shared by gentle-ai review mode status, two git rev-parse and gentle-ai review assess --committed-only --json. On this machine assess alone takes longer than the bound, so delivery is impossible while RDD is on.

Evidence (gentle-pi 4.7.0-main.abf73dc4c25c, Windows 11, Git Bash)

  • gentle-ai review mode status --cwd . : 0.44 s.
  • gentle-ai review assess --cwd . --base-ref <sha> --committed-only --json : 22.3 s on a clean linked worktree (131 changed lines, 0 untracked files, 2 ignored entries).
  • git status --porcelain : 0.32 s.
  • The gentle_review assess tool call on the same worktree recorded durationMs: 19383.
  • Four push attempts with tool timeouts of 90-300 s were each denied about 11-13 s after submission.
  • The same denial appeared in three other repositories the same day.

Expected

A push is not denied only because assess is slow: either the bound is configurable or sized for a normal assess, or a fresh assessment from the same session (same base and HEAD) is reused instead of re-running it inside the bound.

Workaround

gentle-ai review mode disable --scope clone.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions