Updated build and added config support to docker scripts#221
Merged
Gemba merged 1 commit intoGemba:masterfrom Feb 16, 2026
Merged
Updated build and added config support to docker scripts#221Gemba merged 1 commit intoGemba:masterfrom
Gemba merged 1 commit intoGemba:masterfrom
Conversation
rudism
force-pushed
the
docker-improvements
branch
2 times, most recently
from
6f69657 to
33d8536
Compare
rudism
force-pushed
the
docker-improvements
branch
from
33d8536 to
570dc0c
Compare
Owner
|
Cool stuff. Thanks for digging this up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #220 by adding a workdir and removing wildcard from COPY command in the Dockerfile. Also adds the optional ability to provide a
config.iniwhen running the docker scripts (mainly to give the ability to set scraper credentials if desired).I also added
-gand-oarguments to thesave.shscript, since in its current state it was saving thegamelist.xmland media to the docker container's storage instead of the mapped volume, and replacedunattendskipwithunattendso that it can be used to update existing gamelists.Lastly modified the
process_dir.shscript to optionally allow sources to be specified as additional arguments (falling back to the old defaults ofscreenscraperandthegamesdbif not specified).