Skip to content

fix: enable -e option for pegasus#167

Merged
Gemba merged 2 commits intoGemba:masterfrom
cameronhimself:fix/e_option_pegasus
Aug 26, 2025
Merged

fix: enable -e option for pegasus#167
Gemba merged 2 commits intoGemba:masterfrom
cameronhimself:fix/e_option_pegasus

Conversation

@cameronhimself
Copy link
Copy Markdown

Per the documentation, the -e option is supposed to be equivalent to the launch option in the config file for Pegasus. However, it was not working as such for me. So I fumbled around in the code and I'm pretty sure I found the issue.

@Gemba
Copy link
Copy Markdown
Owner

Gemba commented Aug 26, 2025

Yes, you are right. Good catch, I goofed it up.
Thanks for identifying the source and providing the fix.
However, it should also extend the warning message, when -e is honored. You can find a pattern at mediaFolderHidden

If you can update your PR I am happy to merge. If I am asking for too much let me know, then I will fix it by myself.

@cameronhimself
Copy link
Copy Markdown
Author

Oh, whoops. Yep, I'll have that done today.

@cameronhimself
Copy link
Copy Markdown
Author

Looks like it works:

deck@skyscraper:~/code/skyscraper$ ./Skyscraper -f esde -e foo -p snes
------------------------------------------------------------
Running Skyscraper v3.17.4 by Lars Muldjord and contributors
------------------------------------------------------------
Parameter -e is ignored. Only applicable with frontend attractmode or pegasus.

@Gemba Gemba merged commit 32bdb97 into Gemba:master Aug 26, 2025
1 check passed
@Gemba
Copy link
Copy Markdown
Owner

Gemba commented Aug 26, 2025

Awesome. Thanks for the fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants