-
Notifications
You must be signed in to change notification settings - Fork 27
OpenRetro scraper support is broken #169
Description
Describe the bug
Using OpenRetro against obvious game titles fail to match anything. Example debug output:
#5/47592 (T1) Pass 1 ---- Game 'Archipelagos (1989)(Logotron)[cr Threat]' not found :( ----
Debug output:
Compare title: 'Argonaut'
Base name: 'Argonaut (1992)(Mikev Designs)[t +3 Phantasm]'
Search name #1: '/browse?q=argonaut'
Tried with: '/browse?q=argonaut'
Platform : amiga
According to the source, the baseUrl is as expected. If I try the search URI provided in a browser, I get a hit. But, the CLI output says otherwise.
The scraping here appears to be literally a HTML scrape. Looking at this line, here's the HTML from that spot onward:
<div style='margin-bottom: 4px;'><a href="/amiga/archipelagos" target='_parent'><img src="/image/6493666624bef18d04d53a111778ab89abb6e88e?w=140&h=186&t=lbcover" alt="Cover for Archipelagos" title="" style='width: 140px; vertical-align: text-bottom; height: 186px'></a></div>Archipelagos <span style='color: #aaaaaa'>Amiga</span></div></div>That all seems right, from what the variables are looking for. Although, I think EDIT: Sorry, I misread that. The titlePost is wrong here. There is no <span> tag for the title now. This may be the root cause.titlePre is right, and titlePost is after that (duh). I'm back to not knowing what's going on.
To Reproduce
Run any OpenRetro scrape command.
Technical information
Skyscraper version: Latest from RetroPie (3.17.4)