Skip to content

fix: removed snapshot test and added snapshot icon example#4138

Merged
Ajamuar merged 1 commit intominorfrom
feat/remove-snapshot-test-on-commit
Sep 28, 2021
Merged

fix: removed snapshot test and added snapshot icon example#4138
Ajamuar merged 1 commit intominorfrom
feat/remove-snapshot-test-on-commit

Conversation

@Ajamuar
Copy link
Copy Markdown
Contributor

@Ajamuar Ajamuar commented Sep 28, 2021

Summary

The PR is aimed at making the DX better. It includes removing the snapshot test on every commit.

Changelog

Two things have changed in this particular PR:

  • Snapshot test will happen on manual command, i.e. commit-test. Earlier it used to run on pre-commit hook.
  • A snapshot is added for the section Third-party icons in Icon component.

@Ajamuar Ajamuar added the v3 V3 label Sep 28, 2021
@vercel
Copy link
Copy Markdown

vercel bot commented Sep 28, 2021

@Ajamuar Ajamuar requested a review from md-rehman September 28, 2021 11:10
@Ajamuar Ajamuar merged commit 3826a66 into minor Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v3 V3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants