This does not appear to be correct, for one, it shouldn't pass the value into the FC like this.

However, if you follow the other components they appear to have it but it should be ref?

This does not appear to be correct, for one, it shouldn't pass the value into the FC like this.

It should.

However, if you follow the other components they appear to have it but it should be ref?

You mean optional? Because ForwardRefRenderFunction requires a ref, or null, not an optional ref.

function forwardRef<T, P = {}>(render: ForwardRefRenderFunction<T, P>): ForwardRefExoticComponent<PropsWithoutRef<P> & RefAttributes<T>>;

and

type ForwardedRef<T> = ((instance: T | null) => void) | MutableRefObject<T | null> | null;

    interface ForwardRefRenderFunction<T, P = {}> {
        (props: PropsWithChildren<P>, ref: ForwardedRef<T>): ReactElement | null;
        displayName?: string;
        // explicit rejected with `never` required due to
        // https://github.com/microsoft/TypeScript/issues/36826
        /**
         * defaultProps are not supported on render functions
         */
        defaultProps?: never;
        /**
         * propTypes are not supported on render functions
         */
        propTypes?: never;
    }

You mean optional? Because ForwardRefRenderFunction requires a ref, or null, not an optional ref.

If we're following consistency with other components they use ref?: any though that to me is incorrect anyway since it bypasses Typescript checking.

Sorry I know it was merged, I didn't know I had to press "Submit Review" for it to show.

Some other components also use ref: any. It's not consistent, sure, but it's not wrong. Straightening out this inconsistency could be another PR, but brace yourself because the generics can alternate between mobile and web depending on the components you're talking about.

If we follow https://reactjs.org/docs/forwarding-refs.html this is the line that should get the ref as

export default memo(forwardRef((props, ref)=> (<SkeletonCircle ref={ref} {...props} />));

The fc is the same thing, just assigned elsewhere. It's props and then ref.

In other words the forward ref wants a function that takes props and a ref, which is what SkeletonCircle is. A function that accepts props and a ref.

So I'm not sure what you mean. This seems correct to me.

forwardRef technically is a typed function. The second type parameter being a props without the Ref. This would've ensured typesafety, but because of how NativeBase used any in the lower level component the typecheck gets confused if you try to do it properly.

For now as long as the warning disappears I guess we should lave it at that.

Forward ref (typescript, for that matter) doesn't care if you inline or pass through a variable.

But I'm not sure what you're suggesting. Do you mean the generics? Because while those are missing (consistently, which is not good), you can still type them in useRef. Not the prettiest, but also not the scope of this PR. It currently resolves (when typing in useRef) using no types at all.