Skip to content

fix: icon removed when no checked#4067

Merged
Ajamuar merged 1 commit intominorfrom
fix/checkbox
Sep 20, 2021
Merged

fix: icon removed when no checked#4067
Ajamuar merged 1 commit intominorfrom
fix/checkbox

Conversation

@Ajamuar
Copy link
Copy Markdown
Contributor

@Ajamuar Ajamuar commented Sep 20, 2021

Summary

  • Checkbox was using a similar component in both native and web platforms. Unified it under a single component.
  • Replaced check icon with empty box of similar padding to make sure that the check mark was completely disappearing.

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/geekyants-team/native-base/CpvyZu8dzexPhuqRLMA1eAB2WHq9
✅ Preview: https://native-base-git-fix-checkbox-geekyants-team.vercel.app

@Ajamuar Ajamuar requested a review from md-rehman September 20, 2021 06:55
@Ajamuar Ajamuar merged commit 4042395 into minor Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants