Bug fix in matrix-style tracks height computation and fixed CI#105
Merged
Nanguage merged 7 commits intoGangCaoLab:masterfrom Feb 25, 2025
Merged
Bug fix in matrix-style tracks height computation and fixed CI#105Nanguage merged 7 commits intoGangCaoLab:masterfrom
Nanguage merged 7 commits intoGangCaoLab:masterfrom
Conversation
When using style=matrix, PlotHicMat.get_track_height still multiplied track height by 0.8. This was probably the previous way of getting a roughly equal aspect ratio of the matrix since margins were not kept into account in frame width computation. Now that frame width computation is fixed, it actually breaks the aspect ratio. Likely caused by me forgetting to remove the multiplier when frame width computation formula was fixed.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #105 +/- ##
==========================================
+ Coverage 39.74% 39.87% +0.12%
==========================================
Files 81 81
Lines 5271 5440 +169
==========================================
+ Hits 2095 2169 +74
- Misses 3176 3271 +95 ☔ View full report in Codecov by Sentry. |
StefanoCretti
changed the title
Contributor
Author
|
Also fixed CI by:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using style=matrix, PlotHicMat.get_track_height still multiplied track height by 0.8. This was probably the previous way of getting a roughly equal aspect ratio of the matrix since margins were not kept into account in frame width computation. Now that frame width computation is fixed, it actually breaks the aspect ratio.
Likely caused by me forgetting to remove the multiplier when frame width computation formula was fixed.