Toggleable pixel matrix aspect ratio#104
Merged
Nanguage merged 2 commits intoGangCaoLab:masterfrom Feb 12, 2025
Merged
Conversation
Frame.get_track_height, when computing track height dynamically, did not take into account the margins applied at the end of the plotting. Fixed.
Added a new parameter to HicMatBase, 'aspect_ratio', which allows to either keep matrix pixels as squares (new behavior) or to allow matrix pixel stretch to completely fill the subplot (old behavior). "wspace" parameter needs to be removed from Frame.plot to allow tight packing of the matrix like tracks. Same effect can be still achieved by adding spacer tracks. "height += 1.5" in get_track_height is probably not needed, regardless of aspect ratio, but added a check rather than removing it to be sure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow to select aspect ratio of classes inheriting from HicMatBase in order to achieve clearer plotting. Set default to equal aspect ratio. Fixed imprecision in plot width computation.