Skip to content

ci: run required checks on merge-group commits #607

Closed

Description

@wz-gsa

Problem

The active main ruleset requires a merge queue plus Conventional Commit Title, pre-commit, and acq offline suite under bash 3.2. At main 3fe3150, all three owning workflows omit merge_group. No merge_group runs exist. This blocks normal queue completion for dependency PR #591.

Required fix

  • Add main merge_group triggers to pr-lint.yml, pre-commit.yml, and bash32-compat.yml.
  • Gate the PR-only semantic-title action by event while retaining the required context on merge groups.
  • Use the merge-group base SHA for Bash relevance detection instead of the unavailable pull_request.base.sha; retain fail-closed gate behavior.
  • Preserve required context names, read-only permissions, pins, and queue-ref concurrency isolation.
  • Demonstrate all three required contexts on a real merge-group SHA and successful queue progression.

Related verified fix: GSA-TTS/agentic-coding-patterns#524. AI-assisted diagnosis (OpenCode). No ruleset bypass or workflow edit performed.

Activity

  1. mogul commented on Oct 22, 2026

    @mogul
    Contributor

    AI-assisted implementation update (OpenCode): the three-workflow fix is committed locally as 8f99188 on branch unblock-pr-592-merge-queue, based on main 20d6bab. Push was rejected because the sandbox GitHub credential lacks workflow-update permission, so no PR could be opened yet. Unblock trigger: provide the sandbox credential with the appropriate workflow permission, then push the branch and create the PR.

    Verification: YAML, whitespace, EOF, merge-conflict checks and git diff --check passed. Focused shell execution passed missing/malformed base SHA cases, relevant/irrelevant paths, fetch/diff failure cases, and all 16 upstream-result gate combinations. Adversarial subagent review found no blockers. Full local pre-commit was blocked while building pinned gitleaks by no space left on device; actionlint is unavailable. Full PR CI and actual merge-group verification remain pending. The live acceptance criterion remains all three required contexts on a real queue SHA with successful queue progression. This also addresses the queue stall on #592.

  2. mogul commented on Oct 22, 2026

    @mogul
    Contributor

    AI-assisted verification update (OpenCode): fix PR #610 is merged as f54412d (2026-10-22T09:21:23Z). Release PR #592 also merged (2026-10-22T09:22:04Z), resolving its immediate stall. The repository Actions API still reports zero merge_group runs, so these merges do not establish successful live queue validation. Remaining acceptance check: on the next normally queued PR, verify all three required contexts appear on the synthetic merge-group SHA and the queue progresses. Earlier credential/push blocker is resolved by the human host-side push and PR creation.

  3. wz-gsa commented on Oct 23, 2026

    @wz-gsa
    ContributorAuthor

    2026-10-23 sweep: current main now includes merge_group triggers for required workflows. Fresh queue SHA c68077d for591 has Title and Bash gate SUCCESS; pre-commit run39978648342 is executing. Missing-trigger condition is resolved in source; do not close end-to-end acceptance until required checks all pass and queue progresses.

  4. wz-gsa commented on Oct 23, 2026

    @wz-gsa
    ContributorAuthor

    Verified end to end:591 merged as c68077d at2026-10-23T15:39:35Z after all three required merge-group contexts passed (runs39978648342,39978648107,39978648119). Missing-trigger queue blocker resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions