Repository navigation
Commit 94674a3
OpenCode Agent
fix(validators): don't flag runtime secret assignments; fix openchamber MD028
Two CI failures on the openchamber kit PR:
- Markdown Lint (MD028): a blank line between two blockquotes in the kit
README joined them into one block. Replace the blank line with a '>'
continuation line.
- Pattern Validation (sensitive terms): the hardcoded-secret regexes
flagged shell assignments whose value is a command substitution or
variable reference (e.g. OPENCODE_SERVER_PASSWORD="$(cat ...)"). Those
read a secret at runtime, they don't embed a literal, so this was a
false positive. Add a negative lookahead so values starting with $ or
backtick (after an optional quote) are not treated as hardcoded. A real
literal (password="...") is still flagged. Adds unit tests for both
the still-flagged and no-longer-flagged cases.1 parent 18375d9 commit 94674a3
3 files changed
Lines changed: 37 additions & 5 deletions
File tree
- integrations/isolation/sbx-kits/openchamber
- scripts
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | | - | |
| 66 | + | |
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
255 | 255 | | |
256 | 256 | | |
257 | 257 | | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
31 | 35 | | |
32 | 36 | | |
33 | 37 | | |
| |||
0 commit comments