Skip to content

Commit 6bda74b

Browse files
committed
docs(acq-kits): adopt acq publishedPorts translation, drop manual port step (#233 Increment A)
quickstart#221 is merged: acq's neutral→sbx translator now carries backend_extras.sbx.publishedPorts, so applying the openchamber kit publishes container ports 3000/4096 to the host at create time with no manual `acq ports --publish`. Adopt that here (Increment A of #233): - scripts/verify step 2b: instead of always publishing manually, VERIFY the ports were auto-published at create; only fall back to an explicit publish on an older acq that predates #221 (emitted as a non-fatal WARN, not a FAIL). Add a warn() helper for that non-fatal path. - kits.yaml + README: replace the "translator does not yet carry publishedPorts; publish manually" wording with "carried at create (quickstart#221); older acq falls back" and reframe the remaining gap as msb port/background plumbing. Increment B (msb/ppp parity) stays blocked and #233 stays open: acq still has no neutral port-publish/background vocabulary and the msb adapter consumes neither backend_extras.msb ports nor a background flag. No behavior change to the wrapper or startup script. Co-authored-by: OpenCode Agent <[email protected]>
1 parent 6cc4700 commit 6bda74b

3 files changed

Lines changed: 33 additions & 21 deletions

File tree

‎integrations/isolation/acq-kits/kits.yaml‎

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,11 @@ kits:
5454
background). The neutral spec models neither port publishing nor a
5555
background flag, so msb/ppp support is deferred until acq defines a neutral
5656
port-publish + background vocabulary (or the msb adapter grows an
57-
equivalent extra). NOTE: acq's neutral→sbx translator does not yet carry
58-
publishedPorts (fixed upstream in quickstart#221); until that lands in the
59-
pinned kit ref, publish the ports manually with `acq ports --publish`. The
60-
install+supervise script (files/home/openchamber-start.sh) and the wrapper
61-
(files/home/.local/bin/opencode) are backend-agnostic — the only gap is the
62-
port/background plumbing. Tracked as a follow-up on #233.
57+
equivalent extra). acq's neutral→sbx translator now CARRIES publishedPorts
58+
(quickstart#221, merged), so on a current acq the ports are published at
59+
create time with no manual step (older acq: fall back to `acq ports
60+
--publish`). The install+supervise script (files/home/openchamber-start.sh)
61+
and the wrapper (files/home/.local/bin/opencode) are backend-agnostic — the
62+
only remaining gap is msb port/background plumbing, tracked as Increment B
63+
on #233.
6364

‎integrations/isolation/acq-kits/openchamber/README.md‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -212,10 +212,11 @@ release (see the comments in `spec.yaml` and the startup command).
212212
python ../validate-kits.py
213213
214214
# 2. Live end-to-end via acq (preferred). acq translates this neutral kit to an
215-
# sbx-v2 kit and applies it; the verify script then publishes ports 3000/4096
216-
# (acq's translator does not carry backend_extras.publishedPorts), runs the
217-
# wrapper to bring up the shared server, and asserts the wrapper, server,
218-
# OpenChamber, ports, and supervisor. Set a USAi key first for the :4096 check:
215+
# sbx-v2 kit and applies it, carrying backend_extras.sbx.publishedPorts
216+
# (quickstart#221) so ports 3000/4096 publish at create time; the verify
217+
# script confirms that, runs the wrapper to bring up the shared server, and
218+
# asserts the wrapper, server, OpenChamber, ports, and supervisor. Set a USAi
219+
# key first for the :4096 check:
219220
# acq secret set-custom -g --host api.gsa.usai.gov --env USAI_API_KEY
220221
RUN_ACQ=1 ./scripts/verify
221222
RUN_ACQ=1 KEEP=1 ./scripts/verify # keep the sandbox to poke at it

‎integrations/isolation/acq-kits/openchamber/scripts/verify‎

Lines changed: 21 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,10 @@
1616
# Preferred driver — RUN_ACQ=1: drive the `acq` CLI. acq translates the
1717
# neutral hybrid/v1 spec to an sbx-v2 kit (kit_translate_to_sbx) and applies
1818
# it, so the kit's `files:`/`commands:` land correctly. As of quickstart#221
19-
# (merged) acq also carries backend_extras.sbx.publishedPorts, so ports
20-
# 3000/4096 are published at create time; this script still re-publishes
21-
# them idempotently so it also works on an older acq predating that fix.
19+
# (merged) acq carries backend_extras.sbx.publishedPorts, so ports 3000/4096
20+
# are published at CREATE time — no manual step. This script verifies that
21+
# and only falls back to an explicit `acq ports --publish` on an older acq
22+
# that predates #221.
2223
#
2324
# Legacy driver — RUN_SBX=1: drive `sbx` directly on the NEUTRAL spec. sbx
2425
# cannot parse the neutral schema (it expects sbx-v2), so `sbx create --kit`
@@ -76,6 +77,9 @@ fail=0
7677
ok() { printf ' \033[32mPASS\033[0m %s\n' "$1"; pass=$((pass+1)); }
7778
bad() { printf ' \033[31mFAIL\033[0m %s\n' "$1"; fail=$((fail+1)); }
7879
skip() { printf ' \033[33mSKIP\033[0m %s\n' "$1"; }
80+
# warn: a non-fatal note (does NOT count toward fail) — e.g. an older acq took a
81+
# documented fallback path. The run can still pass.
82+
warn() { printf ' \033[33mWARN\033[0m %s\n' "$1"; }
7983
info() { printf '\n\033[1m%s\033[0m\n' "$1"; }
8084

8185
cleanup() {
@@ -177,16 +181,22 @@ if [ "$DRIVER" = "acq" ]; then
177181
sed 's/^/ | /' "$CREATE_LOG" >&2
178182
exit 1
179183
fi
180-
# As of quickstart#221 (merged) acq carries backend_extras.sbx.publishedPorts,
181-
# so a current acq already published 3000/4096 at create. Re-publish explicitly
182-
# anyway: it's idempotent, and it keeps this check working on an older acq that
183-
# predates that fix. Step 7 asserts the mappings actually exist either way.
184-
info "2b. Ensure container ports 3000 and 4096 are published (idempotent; auto as of quickstart#221)"
184+
# As of quickstart#221 (merged) acq carries backend_extras.sbx.publishedPorts
185+
# through translation, so a current acq publishes 3000/4096 at CREATE time — no
186+
# manual step. Verify that here: check the mappings exist post-create. If they
187+
# don't (an older acq predating #221), fall back to an explicit publish so the
188+
# rest of the run still exercises the kit. Step 7 re-asserts the mappings.
189+
info "2b. Container ports 3000 and 4096 published at create (quickstart#221)"
185190
for cport in 3000 4096; do
186-
if acq ports "$SBX_NAME" --publish "${cport}:${cport}" >/dev/null 2>&1; then
187-
ok "published container $cport"
191+
if acq ports "$SBX_NAME" 2>/dev/null | grep -q "$cport"; then
192+
ok "container $cport auto-published at create"
188193
else
189-
bad "failed to publish container $cport (acq ports --publish)"
194+
warn "container $cport not auto-published — older acq (pre-#221)? falling back to manual publish"
195+
if acq ports "$SBX_NAME" --publish "${cport}:${cport}" >/dev/null 2>&1; then
196+
ok "container $cport published via fallback (acq ports --publish)"
197+
else
198+
bad "failed to publish container $cport (acq ports --publish)"
199+
fi
190200
fi
191201
done
192202
else

0 commit comments

Comments
 (0)