@@ -330,6 +330,68 @@ def test_rejects_missing_nonlocal_and_privileged_compose(self, tmp_path):
330330 assert any ("must be a relative kit-local" in e for e in errors ), errors
331331 assert any ("privileged: true" in e for e in errors ), errors
332332
333+ @pytest .mark .parametrize ("value" , ["true" , '"true"' , '"YES"' , '"On"' , '"y"' ])
334+ def test_rejects_compose_truthy_privileged_values (self , tmp_path , value ):
335+ validate_kit = _load_validate_kit ()
336+ kit = _write_kit (
337+ tmp_path / "privileged" ,
338+ "schemaVersion: hybrid/v1\n "
339+ "kind: mixin\n "
340+ "name: privileged\n "
341+ "displayName: Privileged\n "
342+ "description: d\n "
343+ "serviceGateways:\n "
344+ " - name: demo-gateway\n "
345+ " runtime:\n "
346+ " compose:\n "
347+ " files: [compose.yaml]\n "
348+ " service: gateway\n "
349+ " interface:\n "
350+ " protocol: http\n "
351+ " port: 8080\n "
352+ " expose:\n "
353+ " env:\n "
354+ " WEB_GATEWAY_URL: url\n " ,
355+ "services:\n "
356+ " gateway:\n "
357+ " image: ghcr.io/example/gateway:1.0.0\n "
358+ " expose: [8080]\n "
359+ f" privileged: { value } \n " ,
360+ )
361+ errors , _warnings = validate_kit (kit , _load_schema ())
362+ assert any ("privileged: true" in error for error in errors ), errors
363+
364+ @pytest .mark .parametrize ("value" , ["${PRIVILEGED}" , "$PRIVILEGED" ])
365+ def test_rejects_interpolated_privileged_values (self , tmp_path , value ):
366+ validate_kit = _load_validate_kit ()
367+ kit = _write_kit (
368+ tmp_path / "interpolated-privileged" ,
369+ "schemaVersion: hybrid/v1\n "
370+ "kind: mixin\n "
371+ "name: interpolated-privileged\n "
372+ "displayName: Interpolated Privileged\n "
373+ "description: d\n "
374+ "serviceGateways:\n "
375+ " - name: demo-gateway\n "
376+ " runtime:\n "
377+ " compose:\n "
378+ " files: [compose.yaml]\n "
379+ " service: gateway\n "
380+ " interface:\n "
381+ " protocol: http\n "
382+ " port: 8080\n "
383+ " expose:\n "
384+ " env:\n "
385+ " WEB_GATEWAY_URL: url\n " ,
386+ "services:\n "
387+ " gateway:\n "
388+ " image: ghcr.io/example/gateway:1.0.0\n "
389+ " expose: [8080]\n "
390+ f" privileged: { value } \n " ,
391+ )
392+ errors , _warnings = validate_kit (kit , _load_schema ())
393+ assert any ("privileged with Compose interpolation" in error for error in errors ), errors
394+
333395 @pytest .mark .parametrize (
334396 ("compose_yaml" , "expected" ),
335397 [
@@ -384,15 +446,21 @@ def test_rejects_compose_file_indirection(self, tmp_path, compose_yaml, expected
384446 (" volumes: ['/var/run/docker.sock:/var/run/docker.sock']\n " , "Docker socket" ),
385447 (" volumes: ['/:/host:ro']\n " , "host path mount" ),
386448 (" volumes: ['${HOST_ROOT:-/}:/host:ro']\n " , "Compose interpolation" ),
449+ (" volumes: ['$HOME:/host:ro']\n " , "Compose interpolation" ),
387450 (" network_mode: host\n " , "network_mode: host" ),
388451 (" network_mode: ${GW_NETWORK_MODE:-host}\n " , "Compose interpolation" ),
452+ (" pid: $PIDMODE\n " , "Compose interpolation" ),
389453 (" pid: host\n " , "pid: host" ),
390454 (" userns_mode: host\n " , "userns_mode: host" ),
391455 (" ipc: host\n " , "ipc: host" ),
392456 (" cgroup: host\n " , "cgroup: host" ),
393457 (" cap_add: [SYS_ADMIN]\n " , "cap_add" ),
394458 (" security_opt: ['apparmor:unconfined']\n " , "security_opt" ),
395459 (" devices: ['/dev/kvm:/dev/kvm']\n " , "devices" ),
460+ (" device_cgroup_rules: ['b 7:* rmw']\n " , "device_cgroup_rules" ),
461+ (" device_cgroup_rules: $DEVICE_RULES\n " , "device_cgroup_rules with Compose interpolation" ),
462+ (" group_add: ['0']\n " , "group_add" ),
463+ (" group_add: $SUPPLEMENTARY_GROUPS\n " , "group_add with Compose interpolation" ),
396464 (" build: .\n " , "build" ),
397465 ],
398466 )
@@ -422,6 +490,66 @@ def test_rejects_compose_escape_primitives(self, tmp_path, snippet, expected):
422490 errors , _warnings = validate_kit (kit , _load_schema ())
423491 assert any (expected in e for e in errors ), errors
424492
493+ def test_allows_compose_escaped_dollar_in_volume_source (self , tmp_path ):
494+ validate_kit = _load_validate_kit ()
495+ kit = _write_kit (
496+ tmp_path / "escaped-dollar" ,
497+ "schemaVersion: hybrid/v1\n "
498+ "kind: mixin\n "
499+ "name: escaped-dollar\n "
500+ "displayName: Escaped Dollar\n "
501+ "description: d\n "
502+ "serviceGateways:\n "
503+ " - name: demo-gateway\n "
504+ " runtime:\n "
505+ " compose:\n "
506+ " files: [compose.yaml]\n "
507+ " service: gateway\n "
508+ " interface:\n "
509+ " protocol: http\n "
510+ " port: 8080\n "
511+ " expose:\n "
512+ " env:\n "
513+ " WEB_GATEWAY_URL: url\n " ,
514+ "services:\n "
515+ " gateway:\n "
516+ " image: ghcr.io/example/gateway:1.0.0\n "
517+ " expose: [8080]\n "
518+ " volumes: ['$$HOME:/container:ro']\n " ,
519+ )
520+ errors , _warnings = validate_kit (kit , _load_schema ())
521+ assert errors == [], errors
522+
523+ def test_allows_compose_escaped_braced_dollar_in_volume_source (self , tmp_path ):
524+ validate_kit = _load_validate_kit ()
525+ kit = _write_kit (
526+ tmp_path / "escaped-braced-dollar" ,
527+ "schemaVersion: hybrid/v1\n "
528+ "kind: mixin\n "
529+ "name: escaped-braced-dollar\n "
530+ "displayName: Escaped Braced Dollar\n "
531+ "description: d\n "
532+ "serviceGateways:\n "
533+ " - name: demo-gateway\n "
534+ " runtime:\n "
535+ " compose:\n "
536+ " files: [compose.yaml]\n "
537+ " service: gateway\n "
538+ " interface:\n "
539+ " protocol: http\n "
540+ " port: 8080\n "
541+ " expose:\n "
542+ " env:\n "
543+ " WEB_GATEWAY_URL: url\n " ,
544+ "services:\n "
545+ " gateway:\n "
546+ " image: ghcr.io/example/gateway:1.0.0\n "
547+ " expose: [8080]\n "
548+ " volumes: ['$${HOME}:/container:ro']\n " ,
549+ )
550+ errors , _warnings = validate_kit (kit , _load_schema ())
551+ assert errors == [], errors
552+
425553 @pytest .mark .parametrize (
426554 ("compose_yaml" , "expected" ),
427555 [
0 commit comments