Fix buffer overflow when the count of display modes exceeds MaxModePe… #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rScreen(64) 1. Free pModeList memory when destroying instance 2. Add protection when allocating memory for pModeList fails 3. Avoid using an early return 4. Remove the if condition of ppModeList == nullptr, it doesn't match the new calling conventions 5. Always initialize variables
jinjianrong
approved these changes
Nov 5, 2024
kleinerm
added a commit
to kleinerm/Psychtoolbox-3
that referenced
this pull request
Nov 5, 2024
…ure drivers. AMDVLK v-2024.Q4.2 will have a suitable bug fix, so the workaround ain't needed anymore on Navi+ / RDNA gpu's supported by that driver. The fix is untested and not testable by myself as I don't have a RDNA+ gpu, but I performed a full code review and conclude that the bug should be fixed by that fix, which now implements dynamic allocation of suitable data structures, so no hard mode count limit anymore and future proof. Bug report: GPUOpen-Drivers/xgl#179 Bugfix merged 5.11.2024: GPUOpen-Drivers/xgl#180
kleinerm
pushed a commit
to kleinerm/xgl
that referenced
this pull request
Dec 13, 2024
…rScreen(64) (GPUOpen-Drivers#180) 1. Free pModeList memory when destroying instance 2. Add protection when allocating memory for pModeList fails 3. Avoid using an early return 4. Remove the if condition of ppModeList == nullptr, it doesn't match the new calling conventions 5. Always initialize variables Co-authored-by: Li, Wenqing <[email protected]> (cherry picked from commit 786ec85)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rScreen(64)