refactor(theme): collapse git derived color tokens#1453
Merged
limityan merged 1 commit intoJul 7, 2026
Conversation
limityan
force-pushed
the
yanzhn/theme-contract-low-usage-collapse
branch
from
July 7, 2026 09:03
05c446a to
cc00e4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitColors, theme presets,ThemeService, and static root token exports.color-mix()from canonical Git semantic text colors, keepingadded,deleted,changes, and intentionally distinctstagedtext roles.colors.gitcustom-theme keys during normalization, migrate legacy persisted custom themes on load, and keep exported themes aligned with the current Git color contract.docs/architecture/theme-token-optimization.mdso this contraction is captured as a durable contract rule.Metrics
Risk Review
stagedas a separate Git text role because Tokyo Night intentionally differentiates staged and added states; inline added diff lines now read--git-color-added, so they are not visually mislabeled as staged.changesBg,addedBg,deletedBg,stagedBg,addedBgHover,stagedBorder, orpullcontinue to load, butcolors.gitis normalized to the closed Git contract before persistence/export.Related: #1197
Verification
pnpm run theme:color-audit:allpnpm run theme:visual-contractpnpm --dir src/web-ui run test:runpnpm --dir src/web-ui run test:run src/infrastructure/theme/core/ThemeService.test.tspnpm run theme:color-audit:testpnpm run type-check:webpnpm run lint:web(passes with existing bitfun-canvas warnings only)pnpm run build:web(passes with existing Vite chunk/dynamic-import warnings only)git diff --check