Make the cs_sendProcessing a LOCK instead of a TRY_LOCK

TheBlueMatt · furszy · commit c452676b3d23 · 2020-08-01T01:18:42.000-03:00
Technically cs_sendProcessing is entirely useless now because it
is only ever taken on the one MessageHandler thread, but because
there may be multiple of those in the future, it is left in place
diff --git a/src/net.cpp b/src/net.cpp
@@ -1841,9 +1841,8 @@ void ThreadMessageHandler()
 
             // Send messages
             {
-                TRY_LOCK(pnode->cs_sendProcessing, lockSend);
-                if (lockSend)
-                    GetNodeSignals().SendMessages(pnode);
+                LOCK(pnode->cs_sendProcessing);
+                GetNodeSignals().SendMessages(pnode);
             }
             boost::this_thread::interruption_point();
         }

Original file line number	Diff line number	Diff line change
`@@ -1841,9 +1841,8 @@ void ThreadMessageHandler()`
`1841`	`1841`
`1842`	`1842`	`// Send messages`
`1843`	`1843`	`{`
`1844`		`- TRY_LOCK(pnode->cs_sendProcessing, lockSend);`
`1845`		`- if (lockSend)`
`1846`		`- GetNodeSignals().SendMessages(pnode);`
	`1844`	`+ LOCK(pnode->cs_sendProcessing);`
	`1845`	`+ GetNodeSignals().SendMessages(pnode);`
`1847`	`1846`	`}`
`1848`	`1847`	`boost::this_thread::interruption_point();`
`1849`	`1848`	`}`