Startup: move masternode port validation inside initMasternode.

furszy · furszy · commit 2cd0670ed5d8 · 2020-12-23T19:02:58.000-03:00
Do not return an error if a different peer port is used for tor addresses. The peer is behind a hidden service which has the port fixed to the default port.
diff --git a/src/activemasternode.cpp b/src/activemasternode.cpp
@@ -53,6 +53,13 @@ OperationResult initMasternode(const std::string& _strMasterNodePrivKey, const s
         return errorOut(strprintf(_("Invalid -masternodeaddr address: %s"), strMasterNodeAddr));
     }
 
+    // Peer port needs to match the masternode public one for IPv4 and IPv6.
+    // Onion can run in other ports because those are behind a hidden service which has the public port fixed to the default port.
+    if (nPort != GetListenPort() && !addrTest.IsTor() && !params.IsRegTestNet()) {
+        return errorOut(strprintf(_("Invalid -masternodeaddr port %d, isn't the same as the peer port %d"),
+                                  nPort, GetListenPort()));
+    }
+
     CKey key;
     CPubKey pubkey;
     if (!CMessageSigner::GetKeysFromSecret(_strMasterNodePrivKey, key, pubkey)) {
diff --git a/src/init.cpp b/src/init.cpp
@@ -1035,11 +1035,6 @@ bool AppInit2()
     // Exit early if -masternode=1 and -listen=0
     if (gArgs.GetBoolArg("-masternode", DEFAULT_MASTERNODE) && !gArgs.GetBoolArg("-listen", DEFAULT_LISTEN))
         return UIError(_("Error: -listen must be true if -masternode is set."));
-    // Exit early if -masternode=1 and -port is not the default port
-    if (gArgs.GetBoolArg("-masternode", DEFAULT_MASTERNODE) && (GetListenPort() != Params().GetDefaultPort() && !Params().IsRegTestNet()))
-        return UIError(strprintf(_("Error: Invalid port %d for running a masternode."), GetListenPort()) + "\n\n" +
-                       strprintf(_("Masternodes are required to run on port %d for %s-net"), Params().GetDefaultPort(), Params().NetworkIDString()));
-
     if (gArgs.GetBoolArg("-benchmark", false))
         UIWarning(_("Warning: Unsupported argument -benchmark ignored, use -debug=bench."));
 
