Skip to content

Fix invalid custom storage setting fallback - #3

Merged
FullstackSensei merged 1 commit into
mainfrom
workspace-provider-isolation
Nov 2, 2026
Merged

FullstackSensei merged 1 commit into
mainfrom
workspace-provider-isolation

Conversation

@FullstackSensei

Copy link
Copy Markdown
Owner

Description

When customStoragePath is empty, provider profiles use the existing global SecretStorage key.

When the setting has a value, the normalized path selects a separate SecretStorage key. On first use, the manager copies the legacy profile only when no scoped profile exists. It keeps the legacy profile and prefers existing scoped data.

The manager treats non-string setting values as unset. This prevents initialization failures when a configuration mock or invalid value returns the wrong type.

Tests

  • ProviderSettingsManager suite: 69 tests passed.
  • ClineProvider task-history suite with core coverage: 37 tests passed.
  • TypeScript check passed.
  • ESLint passed.

@FullstackSensei
FullstackSensei merged commit c778270 into main Nov 2, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant