Skip to content

Fix space between 'By:' and the author name#8422

Merged
Alkarex merged 5 commits intoFreshRSS:edgefrom
RobLoach:fix-author-space
Jan 10, 2026
Merged

Fix space between 'By:' and the author name#8422
Alkarex merged 5 commits intoFreshRSS:edgefrom
RobLoach:fix-author-space

Conversation

@RobLoach
Copy link
Copy Markdown
Contributor

@RobLoach RobLoach commented Jan 9, 2026

Changes proposed in this pull request:

  • Add a space between "By:" and the author name
  • Replicates the same usage of other gen.short.by_author templates
Screenshot from 2026-01-09 12-57-302

How to test the feature manually:

  1. Load up a Preview of a feed item
  2. Expect that there now is space between "By" and the name of the author

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Jan 9, 2026

That second commit is not a good idea.

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Jan 9, 2026

Putting the onus on translators (and on people double checking the translation) is a lot of extra work at best, and it greatly increases the chance of accidents. :-)

@RobLoach
Copy link
Copy Markdown
Contributor Author

RobLoach commented Jan 10, 2026

Can move it to the text. Was unsure how that would impact other translations, but I'm down.

@RobLoach
Copy link
Copy Markdown
Contributor Author

RobLoach commented Jan 10, 2026

Fixed. Thanks.

@Alkarex Alkarex added this to the 1.28.1 milestone Jan 10, 2026
@Alkarex Alkarex added the I18n 🌍 Translations label Jan 10, 2026
Alkarex
Alkarex reviewed Jan 10, 2026
View reviewed changes
@RobLoach @Alkarex
Apply suggestion from @Alkarex
6443206 
Co-authored-by: Alexandre Alapetite <[email protected]>
@RobLoach
Copy link
Copy Markdown
Contributor Author

RobLoach commented Jan 10, 2026

Thanks for the find.

@Alkarex Alkarex merged commit a5bbd67 into FreshRSS:edge Jan 10, 2026
1 check passed
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Jan 10, 2026

Please add a line for you in https://github.com/FreshRSS/FreshRSS/blob/edge/CREDITS.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alkarex Alkarex Alkarex left review comments

@Frenzie Frenzie Frenzie approved these changes

Assignees

No one assigned

Labels

I18n 🌍 Translations

Projects

None yet

Milestone

1.28.1

Development

Successfully merging this pull request may close these issues.

3 participants

@RobLoach @Frenzie @Alkarex