Skip to content

Switch to using CURLOPT_ACCEPT_ENCODING instead of the deprecated CURLOPT_ENCODING#8376

Merged
Alkarex merged 4 commits intoFreshRSS:edgefrom
mmeier86:8374-fix-curlopt-encoding-issues
Jan 3, 2026
Merged

Switch to using CURLOPT_ACCEPT_ENCODING instead of the deprecated CURLOPT_ENCODING#8376
Alkarex merged 4 commits intoFreshRSS:edgefrom
mmeier86:8374-fix-curlopt-encoding-issues

Conversation

@mmeier86
Copy link
Copy Markdown
Contributor

@mmeier86 mmeier86 commented Dec 31, 2025 •
edited
Loading

Closes #8374

Changes proposed in this pull request:

  • Replacing deprecated CURLOPT_ENCODING with CURLOPT_ACCEPT_ENCODING

As per the CURLOPT_ACCEPT_ENCODING docs, CURLOPT_ENCODING is obsolete since cURL 7.21.6.

How to test the feature manually:

  1. Set up a test instance and add any feet
  2. Observe that adding feeds still works

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated

@mmeier86
Replace deprecated CURLOPT_ENCODING
728c85a 
The CURLOPT_ENCODING setting has been deprecated in favor of
CURLOPT_ACCEPT_ENCODING.

Signed-off-by: Michael Meier <[email protected]>
@mmeier86 mmeier86 mentioned this pull request Dec 31, 2025
Closed
@Alkarex Alkarex added this to the 1.28.1 milestone Dec 31, 2025
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Dec 31, 2025

Thanks!
Let's focus this PR on updating to CURLOPT_ACCEPT_ENCODING and follow up in another one.

The same renaming should be proposed upstream to https://github.com/simplepie/simplepie if you feel like it

@mmeier86 mmeier86 mentioned this pull request Jan 1, 2026
Merged
@mmeier86 mmeier86 changed the title Fix issues with servers sending invalid content-encoding Switch to using CURLOPT_ACCEPT_ENCODING instead of the deprecated CURLOPT_ENCODING Jan 1, 2026
@mmeier86
Copy link
Copy Markdown
Contributor Author

mmeier86 commented Jan 1, 2026

I've adapted the description to focus on replacing CURLOPT_ENCODING only.

In contrast to the SimplePie PR, I did not introduce additional if conditions checking the cURL version, as FreshRSS already requires PHP 8, and PHP 8+ requires cURL 7.29 already.

@mmeier86 mmeier86 marked this pull request as ready for review January 1, 2026 14:21
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Jan 1, 2026

Very good. Please check my suggestion simplepie/simplepie#960 (review) and I will make some merging

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Jan 3, 2026

Merging in progress:

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Jan 3, 2026

@Alkarex Alkarex merged commit b07ec81 into FreshRSS:edge Jan 3, 2026
1 check passed
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Jan 3, 2026

Merged!
Please add a line for you in https://github.com/FreshRSS/FreshRSS/blob/edge/CREDITS.md

mmeier86 added a commit to mmeier86/FreshRSS that referenced this pull request Jan 4, 2026
@mmeier86
Add myself to the credits file
25a6867 
See FreshRSS#8376
@mmeier86 mmeier86 mentioned this pull request Jan 4, 2026
Merged
Alkarex pushed a commit that referenced this pull request Jan 4, 2026
@mmeier86
Add myself to the credits file (#8398)
ed632bb 
See #8376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

SimplePie 🍰

Projects

None yet

Milestone

1.28.1

Development

Successfully merging this pull request may close these issues.

[Bug] Handling of feeds with invalid Content-Encoding is broken

2 participants

@mmeier86 @Alkarex