Skip to content

Fix HTML encoding breaking search in preview filters#8222

Closed
Inverle wants to merge 3 commits intoFreshRSS:edgefrom
Inverle:fix-html-encoding-filteractions
Closed

Fix HTML encoding breaking search in preview filters#8222
Inverle wants to merge 3 commits intoFreshRSS:edgefrom
Inverle:fix-html-encoding-filteractions

Conversation

@Inverle
Copy link
Member

@Inverle Inverle commented Nov 16, 2025

Follow-up of #7959

image

wrongly resulted in

image

@Inverle Inverle added this to the 1.28.0 milestone Nov 16, 2025
@Inverle Inverle added the Bug (confirmed) 🐞 issues that are reproducible label Nov 16, 2025
@Inverle Inverle marked this pull request as draft November 16, 2025 18:20
@Inverle Inverle mentioned this pull request Nov 16, 2025
Merged
4 tasks
@Inverle Inverle marked this pull request as ready for review November 16, 2025 18:49
@Inverle Inverle requested a review from Alkarex November 16, 2025 18:49
@Alkarex Alkarex mentioned this pull request Nov 16, 2025
Merged
@Alkarex
Copy link
Member

Alkarex commented Nov 18, 2025 •
edited
Loading

This PR does not work at the moment. Quick test with intitle:" & " which expects to filter & (with space on each side) in the title, and which does not work anymore. Since the title is saved in database as HTML, the search input must also be as HTML, i.e. &

@Alkarex
Copy link
Member

Alkarex commented Nov 18, 2025

I think the place to fix instead is:

FreshRSS/app/Controllers/categoryController.php

Lines 183 to 188 in a5c4f99

$search = "c:$id (";
foreach ($filteractions as $action) {
$search .= "($action) OR ";
}
$search = preg_replace('/ OR $/', '', $search);
$search .= ')';

By building a BooleanSearch instead of only manual strings:

FreshRSS/app/Models/BooleanSearch.php

Lines 429 to 432 in a5c4f99

/** @param FreshRSS_BooleanSearch|FreshRSS_Search $search */
public function add(FreshRSS_BooleanSearch|FreshRSS_Search $search): void {
$this->searches[] = $search;
}

Alternatively, inspired by the following (which could likely be improved):

FreshRSS/app/Models/BooleanSearch.php

Lines 29 to 38 in 8fdc574

if ($level === 0) {
$input = preg_replace('/:"(.*?)"/', ':"\1"', $input);
if (!is_string($input)) {
return;
}
$input = preg_replace('/(?<=[\s(!-]|^)&quot;(.*?)&quot;/', '"\1"', $input);
if (!is_string($input)) {
return;
}
}

@Inverle Inverle marked this pull request as draft November 20, 2025 21:18
Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Nov 28, 2025
@Alkarex
Fix HTML encoding in preview filters (alternative)
1c3243c 
Alternative to FreshRSS#8222
Follow-up of FreshRSS#8222
@Alkarex Alkarex mentioned this pull request Nov 28, 2025
Merged
@Alkarex
Copy link
Member

Alkarex commented Nov 28, 2025

Alternative in #8259
Tests welcome

@Inverle Inverle closed this Dec 3, 2025
Alkarex added a commit that referenced this pull request Dec 3, 2025
@Alkarex @Inverle
Fix HTML encoding in preview filters (alternative) (#8259)
1621f12 
Alternative to #8222
Follow-up of #8222

Co-authored-by: Inverle <[email protected]>
@Inverle Inverle deleted the fix-html-encoding-filteractions branch December 3, 2025 23:05
@Alkarex Alkarex mentioned this pull request Dec 16, 2025
Merged
Alkarex added a commit that referenced this pull request Dec 17, 2025
@Alkarex
Rework encoding of search filters (#8324)
4bd5035 
Rework:
* #8222

now that we have:
* #8293

Follow-up of:
* #8311

* More simplification

* Deprecate getRawInput
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alkarex Alkarex Awaiting requested review from Alkarex

Assignees

No one assigned

Labels

Bug (confirmed) 🐞 issues that are reproducible

Projects

None yet

Milestone

1.28.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Inverle @Alkarex

Comments