Closed
Conversation
Please review my code to check if the fix is correct. I think that will covers our use cases. I am not very comfortable to have a modified version of SimplePie in the project. I know that it supports plugins, maybe we should look that way to make it easier for us if we need to update the library.
Member
Member
There was a problem hiding this comment.
Please do not make the SimplePie library depend on a function defined in FreshRSS.
The other way around would be acceptable though.
Member
Author
There was a problem hiding this comment.
As you know all the changes introduced to SimplePie. Maybe it would be easier and faster if you take care of it.
Member
There was a problem hiding this comment.
Ok, I will try to do that soon.
Member
Author
There was a problem hiding this comment.
Should I delete the branch or you want to reuse something I wrote?
Member
There was a problem hiding this comment.
Just keep it for the time being. I will do some copy-paste and use it to see the line numbers.
Closed
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Mar 22, 2015
Member
|
Please see #815 |
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Mar 23, 2015
Can simplify the regex (faster because anchored) for cleaning URLs based on the fact that we only have to deal with HTTP or HTTPS FreshRSS#715
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review my code to check if the fix is correct. I think that will covers our use cases. I am not very comfortable to have a modified version of SimplePie in the project. I know that it supports plugins, maybe we should look that way to make it easier for us if we need to update the library.
See #711