i18n: Add Hebrew translation#689
i18n: Add Hebrew translation#689mat-mo wants to merge 1 commit intoFreshRSS:betafrom mat-mo:he-translation
Conversation
|
That was quick :) |
|
Nice :) Note: you have done your PR on the beta branch, you should prefer the dev one ;) Not a problem but we can't merge it. Don't worry we handle that! |
|
Thank a lot, learned something. Will do next time. |
|
I18n is being improved so there is no "official" way to do it ;) |
|
BTW, if you can add a Hebrew feed to the demo it will be easier to point out bugs. |
|
Could you provide one? |
|
http://www.geektime.co.il/ and http://planet.hamakor.org.il/ The first is an israeli tech news blog, the latter is a planet of open source blogs mostly in hebrew, but updates slower than the first one |
|
Thanks. |
|
I was trying to copy your translations but I was not sure if I was doing things correctly as I do not understand Hebrew. I prepared a branch for the translation here https://github.com/FreshRSS/FreshRSS/tree/hebrew-i18n. Could you make a new PR since the i18n method changed recently. Edit: If you still want to contribute, use the files in the branch mentioned above and make your PR on it. I will then merge it to the dev branch. It seems you'll have the interface in Hebrew for the next beta :) |
|
Note I am still working on reorganize i18n files so things are still changing for the moment! |
|
This is the reason i didn't translate yet. Thanks for the heads up. |
|
I have finished to update the i18n files. If you have question about the new system, please ask me. Now instead of having only one file, you have a directory (e.g. |
This is a copy-paste job from mat-mo PR. There is missing translations since it was done prior to the i18n changes. See #689 for more information
|
@mat-mo I just updated the branch with the hebrew translation with what you did in this PR. There is missing translations. |
|
Sorry, i missed what marienfressinaud had done in Dec. I'll look at what you did and try to adjust. Thanks for all your work, both! |
|
Thank you for your contribution. I'll close that PR since it cannot be merge in the current dev branch. Please make a new PR on the hebrew-i18n branch. |
|
Any update on the translation? |
|
Sorry i didn't get to it last week, I'll try to finish tomorrow. |
|
No rush, I just wanted to know if everything was working properly with the new branch |
As requested in #673