Skip to content

i18n: Add Hebrew translation#689

Closed
mat-mo wants to merge 1 commit intoFreshRSS:betafrom
mat-mo:he-translation
Closed

i18n: Add Hebrew translation#689
mat-mo wants to merge 1 commit intoFreshRSS:betafrom
mat-mo:he-translation

Conversation

@mat-mo
Copy link
Copy Markdown

@mat-mo mat-mo commented Oct 30, 2014

As requested in #673

@aledeg
Copy link
Copy Markdown
Member

aledeg commented Oct 30, 2014

That was quick :)
I'll see what I can do in the near future.

@marienfressinaud
Copy link
Copy Markdown
Member

Nice :)

Note: you have done your PR on the beta branch, you should prefer the dev one ;) Not a problem but we can't merge it. Don't worry we handle that!

@mat-mo
Copy link
Copy Markdown
Author

mat-mo commented Oct 30, 2014

Thank a lot, learned something. Will do next time.

@marienfressinaud
Copy link
Copy Markdown
Member

I18n is being improved so there is no "official" way to do it ;)

@mat-mo
Copy link
Copy Markdown
Author

mat-mo commented Oct 30, 2014

BTW, if you can add a Hebrew feed to the demo it will be easier to point out bugs.

@aledeg
Copy link
Copy Markdown
Member

aledeg commented Oct 30, 2014

Could you provide one?

@mat-mo
Copy link
Copy Markdown
Author

mat-mo commented Oct 30, 2014

@aledeg
Copy link
Copy Markdown
Member

aledeg commented Oct 30, 2014

Thanks.
It would probably take some time before we can work on that but at least we have some content to work with

@aledeg
Copy link
Copy Markdown
Member

aledeg commented Dec 4, 2014

I was trying to copy your translations but I was not sure if I was doing things correctly as I do not understand Hebrew. I prepared a branch for the translation here https://github.com/FreshRSS/FreshRSS/tree/hebrew-i18n. Could you make a new PR since the i18n method changed recently.
Sorry to make you work twice.
Thank you

Edit: If you still want to contribute, use the files in the branch mentioned above and make your PR on it. I will then merge it to the dev branch. It seems you'll have the interface in Hebrew for the next beta :)
Could you also provide a picture of a long label (for instance one in the configuration) so we can verify that the rtl is working. Thank you

@marienfressinaud
Copy link
Copy Markdown
Member

Note I am still working on reorganize i18n files so things are still changing for the moment!

@mat-mo
Copy link
Copy Markdown
Author

mat-mo commented Dec 10, 2014

This is the reason i didn't translate yet. Thanks for the heads up.

@marienfressinaud
Copy link
Copy Markdown
Member

I have finished to update the i18n files. If you have question about the new system, please ask me. Now instead of having only one file, you have a directory (e.g. he) and you must reproduce file architecture from the english directory (with admin.php, gen.php, etc.).

aledeg added a commit that referenced this pull request Feb 15, 2015
This is a copy-paste job from mat-mo PR. There is missing translations since it was done prior to the i18n changes.

See #689 for more information
@aledeg
Copy link
Copy Markdown
Member

aledeg commented Feb 15, 2015

@mat-mo I just updated the branch with the hebrew translation with what you did in this PR. There is missing translations.
Could you have a look at that, correct my copy-paste if necessary. Thanks.

@mat-mo
Copy link
Copy Markdown
Author

mat-mo commented Feb 15, 2015

Sorry, i missed what marienfressinaud had done in Dec. I'll look at what you did and try to adjust. Thanks for all your work, both!

@aledeg
Copy link
Copy Markdown
Member

aledeg commented Feb 15, 2015

Thank you for your contribution. I'll close that PR since it cannot be merge in the current dev branch. Please make a new PR on the hebrew-i18n branch.

@aledeg aledeg closed this Feb 15, 2015
@aledeg
Copy link
Copy Markdown
Member

aledeg commented Mar 1, 2015

Any update on the translation?

@mat-mo
Copy link
Copy Markdown
Author

mat-mo commented Mar 1, 2015

Sorry i didn't get to it last week, I'll try to finish tomorrow.

@aledeg
Copy link
Copy Markdown
Member

aledeg commented Mar 1, 2015

No rush, I just wanted to know if everything was working properly with the new branch

@Alkarex Alkarex added the I18n 🌍 Translations label Dec 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

I18n 🌍 Translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants