Skip to content

Initial support for PHP 8.4#6615

Merged
Alkarex merged 3 commits intoFreshRSS:edgefrom
Alkarex:php-8.4
Jul 9, 2024
Merged

Initial support for PHP 8.4#6615
Alkarex merged 3 commits intoFreshRSS:edgefrom
Alkarex:php-8.4

Conversation

@Alkarex
Copy link
Copy Markdown
Member

@Alkarex Alkarex commented Jul 8, 2024 •
edited
Loading

Sole fix needed so far seems to be related to https://wiki.php.net/rfc/deprecate-implicitly-nullable-types

See also upstream PR phpgt/CssXPath#227

We are also hitting a PHP bug with min() function, reported upstream php/php-src#14873

@Alkarex Alkarex added this to the 1.25.0 milestone Jul 8, 2024
@ColonelMoutarde
Copy link
Copy Markdown
Contributor

ColonelMoutarde commented Jul 8, 2024

hi, for help with version upgrades there's rector_php.
i use it at work, it's very handy
https://github.com/rectorphp/rector

@Alkarex
Copy link
Copy Markdown
Member Author

Alkarex commented Jul 8, 2024

hi, for help with version upgrades there's rector_php. i use it at work, it's very handy https://github.com/rectorphp/rector

It does not seem to support PHP 8.4, and not even PHP 8.3, does it?

Rector now supports upgrades from PHP 5.3 to 8.2

@ColonelMoutarde
Copy link
Copy Markdown
Contributor

ColonelMoutarde commented Jul 9, 2024 •
edited
Loading

Support for php8.4 will arrive later this year.
You can already get rid of all the things that will no longer be supported or obsolete with php 7.4/8.1.
we'll have less work to do for 8.4.

@Alkarex
Copy link
Copy Markdown
Member Author

Alkarex commented Jul 9, 2024 •
edited
Loading

This line fails with PHP 8.4.0alpha1 when OPCache is enabled, while the rest seems fine, at a first glance

FreshRSS/app/Models/Feed.php

Line 333 in 58c297f

$value = min($value, 100_000_000);

@Alkarex Alkarex merged commit 0f395da into FreshRSS:edge Jul 9, 2024
@Alkarex Alkarex deleted the php-8.4 branch July 9, 2024 13:57
@Alkarex Alkarex mentioned this pull request Jul 12, 2024
Merged
@Alkarex Alkarex modified the milestones: 1.25.0, 1.24.2 Jul 12, 2024
Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Jul 18, 2024
@Alkarex
Re-enable OPCache for PHP 8.4-alpha2
e629724 
Support https://www.php.net/index.php#2024-07-18-1
Follow-up of FreshRSS#6615
Bug php/php-src#14873 was fixed ndossche/php-src@3d0885f
@Alkarex Alkarex mentioned this pull request Jul 18, 2024
Merged
Alkarex added a commit that referenced this pull request Jul 18, 2024
@Alkarex
Re-enable OPCache for PHP 8.4-alpha2 (#6637)
365cae8 
Support https://www.php.net/index.php#2024-07-18-1
Follow-up of #6615
Bug php/php-src#14873 was fixed ndossche/php-src@3d0885f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.24.2

Development

Successfully merging this pull request may close these issues.

2 participants

@Alkarex @ColonelMoutarde