Draft
Conversation
With new mechanism to better handle links that require autodiscovery (HTML or RSS)
ColonelMoutarde
approved these changes
Aug 16, 2023
| } | ||
| } elseif ($feed->kind() === FreshRSS_Feed::KIND_RSS_MAYBE) { | ||
| $simplePie = $feed->load(false, $feedIsNew); | ||
| // @phpstan-ignore-next-line |
Contributor
There was a problem hiding this comment.
question: why does phpstan have to ignore this line?
Member
Author
There was a problem hiding this comment.
After $feed->load() then $feed->kind() might have changed, but PHPStan does not seem to recognise that and gives an error:
Strict comparison using !== between 3 and 3 will always evaluate to false.
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Sep 1, 2023
fix FreshRSS#5622 Cherry picks on FreshRSS#5584
Merged
Alkarex
added a commit
that referenced
this pull request
Sep 4, 2023
* Fix import with empty content fix #5622 Cherry picks on #5584 * Fix export of tags / labels Article-defined tags were wrongly exported as user-defined labels. * Fix export of tags / labels Article-defined tags were wrongly exported as user-defined labels. * Fix bug with many labels * Better typing * Comments
This was referenced Sep 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5583
With new mechanism
FreshRSS_Feed::KIND_RSS_MAYBEto better handle links that require autodiscovery (HTML or RSS)