Skip to content

PHPStan 7 configureController#5318

Merged
Alkarex merged 1 commit intoFreshRSS:edgefrom
Alkarex:phpstan7-configureController
Apr 19, 2023
Merged

PHPStan 7 configureController#5318
Alkarex merged 1 commit intoFreshRSS:edgefrom
Alkarex:phpstan7-configureController

Conversation

@Alkarex
Copy link
Copy Markdown
Member

@Alkarex Alkarex commented Apr 19, 2023

And fix bugs for saving user queries

And fix bugs for saving user queries
@Alkarex Alkarex added this to the 1.22.0 milestone Apr 19, 2023
@Alkarex Alkarex added System care Everything related to system care Bug (confirmed) 🐞 issues that are reproducible labels Apr 19, 2023

$queries = FreshRSS_Context::$user_conf->queries;
$queries[$id] = new FreshRSS_UserQuery($params, $feed_dao, $category_dao, $tag_dao);
$queries[$id] = (new FreshRSS_UserQuery($queryParams, $feed_dao, $category_dao, $tag_dao))->toArray();
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the ->toArray() that was called magically by FreshRSS_ConfigurationSetter removed in #5251 and broken since

@Alkarex Alkarex merged commit ecd956c into FreshRSS:edge Apr 19, 2023
@Alkarex Alkarex deleted the phpstan7-configureController branch April 19, 2023 22:55
Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Apr 19, 2023
Alkarex added a commit that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug (confirmed) 🐞 issues that are reproducible System care Everything related to system care

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant