Good start, but this not level 9 (517 errors), and not even level 6 (87 errors).

Example:

$ vendor/bin/phpstan analyse --level 6 app/Controllers/
...
 ------ ------------------------------------------------------------------------------ 
  Line   tagController.php                                                             
 ------ ------------------------------------------------------------------------------ 
  :108   Method FreshRSS_tag_Controller::renameAction() has no return type specified.  
 ------ ------------------------------------------------------------------------------ 
...
[ERROR] Found 87 errors

Could you try to pass at least level 6 for the files you are addressing?

I am wondering how did you test that this passed level 9? Maybe a wrong command?

Good start, but this not level 9 (517 errors), and not even level 6 (87 errors).

Example:

$ vendor/bin/phpstan analyse --level 6 app/Controllers/
...
 ------ ------------------------------------------------------------------------------ 
  Line   tagController.php                                                             
 ------ ------------------------------------------------------------------------------ 
  :108   Method FreshRSS_tag_Controller::renameAction() has no return type specified.  
 ------ ------------------------------------------------------------------------------ 
...
[ERROR] Found 87 errors

Could you try to pass at least level 6 for the files you are addressing?

I am wondering how did you test that this passed level 9? Maybe a wrong command?

Hi,
the files that you mention as being in error, are files that I have not touched. I have not done all the files in the controller folder

Check again: the example I gave, tagController.php, is one you have touched, and it does not pass level 6 ;-)

Fair enough if you have not addressed all the controllers, but in this case, the PR description is inaccurate and needs to be corrected...

Up to level 8

Ok, looks good now. The command to check is something like:

$ vendor/bin/phpstan analyse --level 6 app/Controllers/apiController.php app/Controllers/authController.php app/Controllers/categoryController.php app/Controllers/configureController.php app/Controllers/entryController.php app/Controllers/errorController.php app/Controllers/importExportController.php app/Controllers/javascriptController.php app/Controllers/statsController.php app/Controllers/subscriptionController.php app/Controllers/tagController.php 
Note: Using configuration file /home/alexandre/GitHub/FreshRSS/phpstan.neon.
 11/11 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


                                                                                                                        
 [OK] No errors