Merged
Conversation
Before, when adding a simple integration, the delete button was missing until the configuration was saved. This behavior was introduced in FreshRSS#4269, but I think that it was a regression. Now, the delete button is back and everything is working as it should. In the process, I've extracted templates in attributes and add them in template tags. This way, it is easier to validate that the HTML code is valid.
aledeg
force-pushed
the
fix/integration-page
branch
from
a61225f to
4a79b36
Compare
Member
|
And nicer code :-) |
Member
Author
Thanks! |
math-GH
pushed a commit
to math-GH/FreshRSS
that referenced
this pull request
Nov 15, 2022
Before, when adding a simple integration, the delete button was missing until the configuration was saved. This behavior was introduced in FreshRSS#4269, but I think that it was a regression. Now, the delete button is back and everything is working as it should. In the process, I've extracted templates in attributes and add them in template tags. This way, it is easier to validate that the HTML code is valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
How to test the feature manually:
Pull request checklist:
Additional information can be found in the documentation.
Before, when adding a simple integration, the delete button was missing until the configuration was saved. This behavior was introduced in #4269, but I think that it was a regression.
Now, the delete button is back and everything is working as it should.
In the process, I've extracted templates in attributes and add them in template tags. This way, it is easier to validate that the HTML code is valid.