fixed: Swage theme - Config dropdown menu on small resulutions#4512
Merged
Alkarex merged 1 commit intoFreshRSS:edgefrom Aug 19, 2022
Merged
fixed: Swage theme - Config dropdown menu on small resulutions#4512Alkarex merged 1 commit intoFreshRSS:edgefrom
Alkarex merged 1 commit intoFreshRSS:edgefrom
Conversation
Contributor
Author
|
@Alwaysin please have a look here :) The fix was easier than I thought before. |
Frenzie
reviewed
Aug 18, 2022
| max-height: calc(100vh - 45px); | ||
| overflow: scroll; | ||
|
|
||
| .icon { |
Member
There was a problem hiding this comment.
Is this change on purpose? It looks quite unrelated to the overflow stuff.
Contributor
Author
There was a problem hiding this comment.
it was by purpose.
.dropdown .icon is the same like .dropdown .dropdown-menu .icon, so .dropdown .dropdown-menu can be used for the (new) scrolling and for the .icon
Contributor
I tried it and it works as expected! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4511
After:
Dropdown menu is scrollable
Changes proposed in this pull request:
How to test the feature manually:
Pull request checklist: