Skip to content

Article css filtering#4501

Merged
Alkarex merged 56 commits intoFreshRSS:edgefrom
papaschloss:css-filtering
Aug 15, 2022
Merged

Article css filtering#4501
Alkarex merged 56 commits intoFreshRSS:edgefrom
papaschloss:css-filtering

Conversation

@papaschloss
Copy link
Copy Markdown
Contributor

@papaschloss papaschloss commented Aug 12, 2022

lets you add comma separated CSS selectors that will be removed from the extracted article content. Preview, import, and export work too. Let me know what else I can do to make this PR better

How to test the feature manually:

  1. Add a feed with CSS selector and filtering to make sure the filtered elements are removed
  2. Add a feed with CSS selector and no filtering to make sure plain old filtering works
  3. Preview a feed via the css selector to make sure the css filters are removed in the preview
  4. Export and import to make sure filtering OPML elements work correctly

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Aug 12, 2022

Thanks and welcome! 👍🏻

@Alkarex Alkarex added this to the 1.20.0 milestone Aug 12, 2022
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Aug 12, 2022

Please run make fix-all and make test-all if you can

@papaschloss
Copy link
Copy Markdown
Contributor Author

Updated to use the json attributes storage instead of DB column. These changes fix the fix-all and test-all issues too.

@math-GH
Copy link
Copy Markdown
Contributor

math-GH commented Aug 13, 2022

I do not understand it :/

How is it related to #3406 (it is about creating a new theme)?

papaschloss and others added 4 commits August 14, 2022 09:54
Co-authored-by: Alexandre Alapetite <[email protected]>
Co-authored-by: Alexandre Alapetite <[email protected]>
Co-authored-by: Alexandre Alapetite <[email protected]>
@papaschloss
Copy link
Copy Markdown
Contributor Author

all issues are fixed

@Alkarex Alkarex merged commit 8587efa into FreshRSS:edge Aug 15, 2022
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Aug 15, 2022

@nfriedly
Copy link
Copy Markdown

Thank you for adding this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Idea - exclude certain CSS elements from page

4 participants