Skip to content

Fix: Mapco theme cleaning#4491

Merged
Alkarex merged 21 commits intoFreshRSS:edgefrom
math-GH:theme-more-small-fixes
Aug 6, 2022
Merged

Fix: Mapco theme cleaning#4491
Alkarex merged 21 commits intoFreshRSS:edgefrom
math-GH:theme-more-small-fixes

Conversation

@math-GH
Copy link
Copy Markdown
Contributor

@math-GH math-GH commented Aug 5, 2022

The Mapco theme is one of the most favorite themes (see #4295), but it has some broke UI

Before (login page)
grafik

After (login page):
The form has now the same grey background as in the configuration. Now it can uses the default form components. The width of the form is a bit wider.
The search button is not blue, when the search is not focused (the search button becomes blue, when the mouse hovers or the focus is inside the search input).
grafik

Before (registration page):
grafik

After (registration page):
same layout like the login page.
The select box has now the same size like the inputs
grafik

Before (configs)
grafik

After (configs)
The select box has now the same size like the inputs
grafik

Before (menu buttons)
grafik

After (menu buttons)
Hover background is set to a darker grey. It is now the same like the other buttons within .stick
grafik

Changes proposed in this pull request:

  • clean up the (S)CSS
  • delete commented out lines
  • translated the French comments into English comments
  • delete unused icons
  • compress icons

How to test the feature manually:
see before/after screenshots

Pull request checklist:

  • clear commit messages
  • code manually tested

@math-GH math-GH added this to the 1.20.0 milestone Aug 5, 2022
@math-GH math-GH marked this pull request as ready for review August 6, 2022 16:40
@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Aug 6, 2022

Ready for review.

(btw: I was very suprised, that Mapco is one of the most favorite themes, while it had so many UI bugs)

After reviewing this PR I will do the same with Ansum theme, that is similar.

@Alkarex Alkarex merged commit 0cb9f59 into FreshRSS:edge Aug 6, 2022
@math-GH math-GH deleted the theme-more-small-fixes branch August 29, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants