Refactor entry-to-GReader API format#4490
Merged
Alkarex merged 4 commits intoFreshRSS:edgefrom Aug 8, 2022
Merged
Conversation
Some code was copied in two locations and not completely uniform. Cleaning of related variables and functions (e.g. better types for entries and categories as objects vs. as IDs). Usecase: I need to call the same GReader-compatible serialization from an extension
`summary` and `content` seems to be used interchangeably in the Google Reader API. We have been using `summary` for our client API and `content` in our export/import, so stick to that.
Merged
Alkarex
commented
Sep 3, 2023
| $entry->_feed($feed); | ||
|
|
||
| if (isset($this->entryIdsTagNames['e_' . $entry->id()])) { | ||
| $entry->_tags($this->entryIdsTagNames['e_' . $entry->id()]); |
Member
Author
There was a problem hiding this comment.
This wrongly mixed tags and labels. Regression fixed in #5626
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some code was duplicated and not completely uniform.
Cleaning of related variables and functions (e.g. better types for entries and categories as objects vs. as IDs).
Use-case: I need to call the same GReader-compatible serialization from an extension