Skip to content

Fix: [BUG] "Hide after read" and "mark on scroll" clears the whole list feed by feed.#4471

Merged
Alkarex merged 1 commit intoFreshRSS:edgefrom
math-GH:fix-4446-auto-mark-read
Jul 31, 2022
Merged

Fix: [BUG] "Hide after read" and "mark on scroll" clears the whole list feed by feed.#4471
Alkarex merged 1 commit intoFreshRSS:edgefrom
math-GH:fix-4446-auto-mark-read

Conversation

@math-GH
Copy link
Copy Markdown
Contributor

@math-GH math-GH commented Jul 28, 2022

Closes #4446

Before: If the unread article is <40 pixels below the top edge, it was marked as read
After: If the unread article is > 5 pixels above the top edge, it is marked as read

Changes proposed in this pull request:

  • +40 pixels -> -5 pixels
  • use a const for better documentation/readability of the source code (maybe you can find a better const name)

How to test the feature manually:

  1. enable "Mark an article as read… while scrolling" (Config -> Reading)
  2. enable "Hide articles after reading" (Config -> Reading)
  3. have a list of unread articles
  4. scroll down
  5. wait
  6. it does not autom. mark articles as read one by one

Pull request checklist:

  • clear commit messages
  • code manually tested

@math-GH math-GH added the View label Jul 28, 2022
@math-GH math-GH added this to the 1.20.0 milestone Jul 28, 2022
@Alkarex Alkarex merged commit c5ff838 into FreshRSS:edge Jul 31, 2022
@math-GH math-GH deleted the fix-4446-auto-mark-read branch July 31, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] "Hide after read" and "mark on scroll" clears the whole list feed by feed.

2 participants