Skip to content

Implemented advanced feed settings to allow cookies and HTTP redirects.#4470

Merged
Alkarex merged 3 commits intoFreshRSS:edgefrom
rdmitr:cookies-and-redirects
Aug 20, 2022
Merged

Implemented advanced feed settings to allow cookies and HTTP redirects.#4470
Alkarex merged 3 commits intoFreshRSS:edgefrom
rdmitr:cookies-and-redirects

Conversation

@rdmitr
Copy link
Copy Markdown
Contributor

@rdmitr rdmitr commented Jul 27, 2022

Closes #

I have noticed that one of my feeds tries to perform an HTTP redirect while setting a cookie (some kind of spam/rate limiting thing I guess). Neither option is currently supported by FreshRSS, so I added them as advanced feed options.

Changes proposed in this pull request:

  • Add the advanced feed options to allow cookies and HTTP redirects. Both are disabled by default.

How to test the feature manually:

  1. When subscribing to a feed, open the "Advanced" settings menu and set the "Allow cookies" option, and a value of 5 for HTTP redirects;
  2. Subscribe to the feed;
  3. In the "feed" database table, check the "attributes" column. Observe the following attributes:
    1. "10031": "" (CURLOPT_COOKIEFILE)
    2. "68": 5 (CURLOPT_MAXREDRS)
    3. "52": 1 (CURLOPT_FOLLOWLOCATION)

A similar sequence of actions can be performed to manually test modification of these attributes on an existing feed.

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated

@Alkarex Alkarex added this to the 1.20.0 milestone Jul 28, 2022
@Alkarex Alkarex merged commit 0ec6578 into FreshRSS:edge Aug 20, 2022
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Aug 20, 2022

Looks all good! Sorry for the delay, and thanks again 👍🏻
Please add a line for you in https://github.com/FreshRSS/FreshRSS/blob/edge/CREDITS.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants