Conversation
Co-authored-by: Alexandre Alapetite <[email protected]>
Co-authored-by: Alexandre Alapetite <[email protected]>
lib/lib_rss.php
Outdated
| $details = "<pre>{$details}</pre>"; | ||
| } | ||
|
|
||
| header('HTTP 1.1 500 Internal Server Error', true, 500); |
There was a problem hiding this comment.
The function errorMessageInfo() returns some text so it should avoid emitting headers (side effect). I suggest to move this line in the killApp() function.
There was a problem hiding this comment.
see my comment above
There was a problem hiding this comment.
We could throw new Minz_Exception($error); in https://github.com/FreshRSS/FreshRSS/blob/edge/p/i/index.php#L65-L69 instead of the two last lines
There was a problem hiding this comment.
Could you please support here with a change/push?
| } | ||
|
|
||
| header('HTTP 1.1 500 Internal Server Error', true, 500); | ||
| header("Content-Security-Policy: default-src 'self'"); |
There was a problem hiding this comment.
Similar to comment just above, except that I am not sure of where to best put that line, so maybe just leave it there for now
2 participants
Before:
After:
Changes proposed in this pull request:
<!DOCTYPE><html><header><title><body>....</body></html>How to test the feature manually:
page=abc)Pull request checklist: