Skip to content

Fix: header height#4452

Merged
Alkarex merged 3 commits intoFreshRSS:edgefrom
math-GH:fix-header-height
Jul 19, 2022
Merged

Fix: header height#4452
Alkarex merged 3 commits intoFreshRSS:edgefrom
math-GH:fix-header-height

Conversation

@math-GH
Copy link
Copy Markdown
Contributor

@math-GH math-GH commented Jul 18, 2022

Before:
grafik

After:
grafik

Changes proposed in this pull request:

  • Set a fixed height to the header
  • calculate the height of the #global
  • default header height is now 85px (some themes have another height)

How to test the feature manually:

  1. test it with every theme
  2. go to normal view and mark all articles as read
  3. check the left navigation footer

Pull request checklist:

  • clear commit messages
  • code manually tested

@math-GH math-GH added this to the 1.20.0 milestone Jul 18, 2022
@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Jul 18, 2022

Kudos to @Frenzie who gave an idea (see: #4447 (comment))

@Alkarex Alkarex merged commit 6352a1d into FreshRSS:edge Jul 19, 2022
@math-GH math-GH deleted the fix-header-height branch July 21, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants