Skip to content

Fix #4447: Nord theme#4451

Merged
Alkarex merged 3 commits intoFreshRSS:edgefrom
math-GH:fix-4447
Jul 17, 2022
Merged

Fix #4447: Nord theme#4451
Alkarex merged 3 commits intoFreshRSS:edgefrom
math-GH:fix-4447

Conversation

@math-GH
Copy link
Copy Markdown
Contributor

@math-GH math-GH commented Jul 17, 2022

Closes #4447
ref. #4400

Changes proposed in this pull request:

  • html need height: 100%
  • added it to template.css
  • removed html {height: 100%} from the themes, because it is included in template.css now

How to test the feature manually:

  1. use Nord theme
  2. scroll in normal view down
  3. check, that it does not loead to much next articles

Pull request checklist:

  • clear commit messages
  • code manually tested

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Jul 17, 2022

Which themes have it "added" this way? Any besides Nord?

@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Jul 17, 2022

Which themes have it "added" this way? Any besides Nord?

Before:
every theme had included html {height: 100%}, except Nord theme.

Now:
every theme has included html {height: 100%} via template.css

@Alkarex Alkarex added this to the 1.20.0 milestone Jul 17, 2022
Copy link
Copy Markdown
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, cool, very safe then. :-)

@Alkarex Alkarex merged commit 954fcef into FreshRSS:edge Jul 17, 2022
@math-GH math-GH deleted the fix-4447 branch July 17, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nord theme: loads every article

3 participants