Hello and thanks for your contribution 👍🏻
I have automatically fixed a number of issues by running make fix-all and make test-all, but there are a few issues remaining (see the output of the automated tests below)

Hello and thanks for your contribution 👍🏻 I have automatically fixed a number of issues by running make fix-all and make test-all, but there are a few issues remaining (see the output of the automated tests below)

Thank you, do you know of how to pull the changes you did to my repo, so I can fix these problems?

Thank you, do you know of how to pull the changes you did to my repo, so I can fix these problems?

git pull --ff-only

regarding your CSS:

Here you can find the defined order of CSS properties:

For the order of attributes and other cosmetic things, running make fix-all automatically fixes all that. I have just done it, so the few remaining errors are those that must be manually handled

regarding your CSS:

Here you can find the defined order of CSS properties:

FreshRSS/.stylelintrc.json

Lines 40 to 65 in f85c510

	"order/properties-order": [
	"margin",
	"padding",
	"background",
	"display",
	"float",
	"max-width",
	"width",
	"max-height",
	"height",
	"color",
	"font",
	"font-family",
	"font-size",
	"border",
	"border-top",
	"border-top-color",
	"border-right",
	"border-right-color",
	"border-bottom",
	"border-bottom-color",
	"border-left",
	"border-left-color",
	"border-radius",
	"box-shadow"
	],

Thanks, I noticed there are some tests which let me know the line numbers where the css is wrong. But as I edit changes those line numbers wrong and I kinda laze around.

Is there a way to run those tests locally? I think I lack some dependencies but idk which ones, sorry if this is in the documentation, I should re-check

Well, not a lot of errors left, I'll fixed them now

To run tests locally, try make fix-all and make test-all
Otherwise in your case, npm install and npm run fix and npm test will cover most of what you need.
In both cases, nodejs + npm must to be available

Well now there are more errors 🙃

Hey, it passed, thank you @Alkarex I couldn't manage to get the make running since I still lacked some smaller depenencies. But now its working!

Please check the menus in mobile view.

The "user query" submenu is broken (the white rhombus is part of the submenu)

And the config menu: the close button looks not styled:

Hint 2: We are using https://editorconfig.org/ to specify whitespace policies for various types of files in a standard way. This is supported by most editors, either natively or thanks to a plugin

Hint 2: We are using https://editorconfig.org/ to specify whitespace policies for various types of files in a standard way. This is supported by most editors, either natively or thanks to a plugin

Thank you, I installed the plugin for neovim and also removed some configs I had set myself that were conflicting. It should be good now! Sorry

Please double-check the global view

A few things are strange, in particular the background colour of article lists:

I cannot replicate this issue, I tried both in chromium and firefox...

Please double-check the global view

A few things are strange, in particular the background colour of article lists:

I can confirm this issue with Firefox on Windows

I can confirm this issue with Firefox on Windows

I don't really know how to solve this, my guess is that some some CSS needs an !important added to it. If any of you could find which one is it and add it it would be better since I can't get this to work...

I can confirm this issue with Firefox on Windows

I don't really know how to solve this, my guess is that some some CSS needs an !important added to it. If any of you could find which one is it and add it it would be better since I can't get this to work...

fixed

Thanks again!
Please add a line for you in https://github.com/FreshRSS/FreshRSS/blob/edge/CREDITS.md

I like the theme! 👍

There seems to not be the new message notification banner, is this a feature?

I like the theme! 👍

There seems to not be the new message notification banner, is this a feature?

This is based on the default template and it has nothing else added.
When there are new posts available there is a little message showing up a the top of the feed, do you mean that?

Yes, I meant that. Sorry, I probably had a problem on my side, it is now showing correctly!

I think there's definetly a problem with this theme. On latest Chrome version on Windows, my tab of FreshRSS uses less than 200Mo of memory. When I switch to this theme, it uses circa 1Go. That's probably why it sometimes don't show the banner.
It is even more visible on a mobile phone, everything is so slow.

EDIT: Got it, the theme is loading EVERY article. I have 14000+ unread, so yeah.

The theme has no effect on the loading behavior. The theme is just the layout (made with CSS).

How to check the resource usage in Google Chrome: https://linuxhint.com/built_in_task_manager_google_chrome/

@math-GH this is the exact tool I've used to check memory status.
When using Nord theme, as soon as I scroll down, it loads every article and memory usage skyrockets. It doesn't do it on other themes.

Loading next articles while scrolling: it is a default behavior and does not depending on the theme:

Maybe I'll do a video of the behaviour if I find time to do so.
I indeed have this feature on, but on other themes, it works as described: it loads at the bottom of te page.
Ths theme, as soon as I scroll, even a millimeter, it loads everything.

OK, now I understood and can confirm that behavior.

I created an issue ticket: #4447