Skip to content

Custom logo HTML#4369

Merged
Alkarex merged 7 commits intoFreshRSS:edgefrom
Alkarex:custom_logo
May 23, 2022
Merged

Custom logo HTML#4369
Alkarex merged 7 commits intoFreshRSS:edgefrom
Alkarex:custom_logo

Conversation

@Alkarex
Copy link
Copy Markdown
Member

@Alkarex Alkarex commented May 16, 2022

Add option for custom HTML logo/title in the main Web UI view.
Can potentially be different per user.
#fix https://github.com/FreshRSS/FreshRSS/pull/3830/files#r850472247

Add option for custom HTML logo/title in the main Web UI view.
Can potentially be different per user.
#fix https://github.com/FreshRSS/FreshRSS/pull/3830/files#r850472247
@Alkarex Alkarex added the UI 🎨 User Interfaces label May 16, 2022
@Alkarex Alkarex added this to the 1.20.0 milestone May 16, 2022
@Alkarex Alkarex mentioned this pull request May 16, 2022
2 tasks
@Alkarex
Copy link
Copy Markdown
Member Author

Alkarex commented May 16, 2022

@marienfressinaud Could that work for your own needs as well?

@math-GH
Copy link
Copy Markdown
Contributor

math-GH commented May 16, 2022

Is it a "hidden" feature that cannot configured via the config menu?

@Alkarex
Copy link
Copy Markdown
Member Author

Alkarex commented May 16, 2022

Is it a "hidden" feature that cannot configured via the config menu?

For now yes, but could be exposed in the HTML UI if there is a demand

@math-GH
Copy link
Copy Markdown
Contributor

math-GH commented May 19, 2022

I am not a big fan that it is tied to the user's settings and not to the system's settings. I would say, that in very rare cases the user has the access to the config files, mostly the user is admin.
I would not expect, that I - as a user - could edit my config file. As a admin I would expect to edit the system's config files.

@Alkarex
Copy link
Copy Markdown
Member Author

Alkarex commented May 19, 2022

@math-GH My thought was to define it in ./data/config-user.custom.php prior to creating a user, but fair enough

@marienfressinaud
Copy link
Copy Markdown
Member

@marienfressinaud Could that work for your own needs as well?

Yes, it should. Could you add "FreshRSS" to the alt attribute as well?

I am not a big fan that it is tied to the user's settings and not to the system's settings.

I agree: if I want to change the logo, I don't want to change it for each user one by one.

Alkarex added 2 commits May 21, 2022 18:30
With new `./data/config.custom.php` to provide custom values before install
@Alkarex
Copy link
Copy Markdown
Member Author

Alkarex commented May 21, 2022

Ok, new approach with logo_html in main config.
With new ./data/config.custom.php to provide custom values before install

@Alkarex Alkarex requested a review from marienfressinaud May 21, 2022 18:07
@math-GH
Copy link
Copy Markdown
Contributor

math-GH commented May 22, 2022

(comment deleted. It did it wrong. Forgot to pull. Sorry. My fault)

@math-GH
Copy link
Copy Markdown
Contributor

math-GH commented May 22, 2022

It works fine for me (did not test it with a fresh new instance).

2 side notes:

  • a documentation in the docs is needed
  • any ideas how to style it? Inline CSS is not permitted. Theme CSS does not cover this feature. CustomCSS extension does not cover every user. Maybe "logo_html" should active an additional CSS file?

@Alkarex
Copy link
Copy Markdown
Member Author

Alkarex commented May 22, 2022

Regarding styling, the CSS extension can be used to style a class, or the logo_html can point to a CSS file:

'logo_html' => '<link rel="stylesheet" href="../themes/xCustom/logo.css" /><img class="logo" src="https://example.net/logo.png" alt="Logo" />',

@Alkarex
Copy link
Copy Markdown
Member Author

Alkarex commented May 22, 2022

@math-GH Some documentation added

@Alkarex Alkarex merged commit f89819b into FreshRSS:edge May 23, 2022
@Alkarex Alkarex deleted the custom_logo branch May 23, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI 🎨 User Interfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants