Skip to content

Improve: reduce size when tagEntry#4366

Merged
Alkarex merged 1 commit intoFreshRSS:edgefrom
BlueWhale235:tagEntry_redirect
May 15, 2022
Merged

Improve: reduce size when tagEntry#4366
Alkarex merged 1 commit intoFreshRSS:edgefrom
BlueWhale235:tagEntry_redirect

Conversation

@BlueWhale235
Copy link
Copy Markdown
Contributor

Changes proposed in this pull request:

-When I add a tag to a article, I find that the response is too large. I think it needn't request all contents. So I add a "ajax" opinion.
-Screen Shots:
-Before
屏幕截图 2022-05-15 141444

-After
屏幕截图 2022-05-15 135254

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated

Copy link
Copy Markdown
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that all works, lgtm. Btw, not directly related to this PR but the indentation looks a bit weird on those last 4 lines.

@Alkarex Alkarex added this to the 1.20.0 milestone May 15, 2022
@BlueWhale235
Copy link
Copy Markdown
Contributor Author

I just add a line, this is what the previous person left behind.
Also, what does "lgtm" mean? I don't really understand because I'm not a native English speaker.

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented May 15, 2022

@BuleWhale Thanks, good idea with this PR. lgtm means looks good to me

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented May 15, 2022

@Frenzie No indentation problem, just a strange GitHub visualisation with a difference between the lines that are part of the patch or not

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented May 15, 2022

Related to #4310

@Alkarex Alkarex merged commit 5736ec6 into FreshRSS:edge May 15, 2022
@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented May 15, 2022

@Alkarex You mean this is a visualization problem with regard to the number of equivalent spaces it chooses for tabs?
Screenshot 2022-05-15 at 13-54-07 Improve reduce size when tagEntry by BuleWhale · Pull Request #4366 · FreshRSS_FreshRSS

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented May 15, 2022

Indeed @Frenzie . It looks fine when looking at the full document

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants