User query automatic reconstruct of URL#4360
Merged
Alkarex merged 2 commits intoFreshRSS:edgefrom May 15, 2022
Merged
Conversation
(Invisible through the Web UI, only when working with configuration files manually) Avoid the requirement of storing user queries with duplicated information (parsed parameters AND the resulting URL): Before: ``` [ 'name' => 'Hello', 'search' => 'Hello OR World', 'state' => '3', 'url' => './?search=Hello+OR+World&state=3', ] ``` After: ``` [ 'name' => 'Hello', 'search' => 'Hello OR World', 'state' => '3', ] ```
Member
Author
|
@aledeg I have not changed it yet, but we could also consider not saving the |
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
May 16, 2022
Fix bug when taking advantage of FreshRSS#4360 At one place, the raw URL parameter was accessed instead of being reconstructed
Member
Author
Alkarex
added a commit
that referenced
this pull request
May 17, 2022
Fix bug when taking advantage of #4360 At one place, the raw URL parameter was accessed instead of being reconstructed
Member
|
I do not remember. |
Member
Author
|
No worries @aledeg :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Invisible through the Web UI, only when working with user configuration files manually)
Avoid the requirement of storing user queries with duplicated information (parsed parameters AND the resulting URL):
Before:
After: