Skip to content

Option icons-as-emojis for performance#4353

Merged
Alkarex merged 1 commit intoFreshRSS:edgefrom
Alkarex:performance-emoji
May 9, 2022
Merged

Option icons-as-emojis for performance#4353
Alkarex merged 1 commit intoFreshRSS:edgefrom
Alkarex:performance-emoji

Conversation

@Alkarex
Copy link
Copy Markdown
Member

@Alkarex Alkarex commented May 7, 2022 •
edited
Loading

New mode to use only emojis instead of icons.
Considerably improves performances.
Needed for the 20k+ feeds scenario #4347
The main problem was the ⚙️ configuration image in the list of feeds on the left (together with the existing option to hide favicons #2821 )

@Alkarex
Option icons-as-emojis for performance
4bb1491 
New mode to use only emojis instead of icons.
Considerably improves performances.
Needed for 20k+ feeds scenario FreshRSS#4347
@Alkarex Alkarex added the UI 🎨 User Interfaces label May 7, 2022
@Alkarex Alkarex added this to the 1.20.0 milestone May 7, 2022
@Alkarex Alkarex mentioned this pull request May 7, 2022
Merged
@Alkarex
Copy link
Copy Markdown
Member Author

Alkarex commented May 7, 2022

Here is how this mode looks like:
image

Frenzie
Frenzie approved these changes May 7, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. :-)

@Alkarex Alkarex merged commit 80a228e into FreshRSS:edge May 9, 2022
@Alkarex Alkarex deleted the performance-emoji branch May 9, 2022 10:54
Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request May 26, 2022
@Alkarex
Fix warning with icons
28415c0 
Fix warning in cases when the user context is not yet available, for instance during install
Fix regression from FreshRSS#4353
@Alkarex Alkarex mentioned this pull request May 26, 2022
Merged
Alkarex added a commit that referenced this pull request May 30, 2022
@Alkarex
Fix warning with icons (#4390)
15cdb60 
Fix warning in cases when the user context is not yet available, for instance during install
Fix regression from #4353
@ParoTheParrot
Copy link
Copy Markdown
Contributor

ParoTheParrot commented Sep 12, 2022

How can I use this option?
I didn't find this in the configuration menu.
And my attempt with a config-user.custo.phpon./data does not work.

I need advice, TIA!

@Alkarex
Copy link
Copy Markdown
Member Author

Alkarex commented Sep 12, 2022

How can I use this option? I didn't find this in the configuration menu. And my attempt with a config-user.custo.phpon./data does not work.

@ParoTheParrot Hello,
There is no UI for it at the moment, so you need to change the option in ./freshrss/data/users/alice/config.php

./data/config-user.custom.php is only used as a template when creating a new user and will not modify the settings for existing users

@ParoTheParrot
Copy link
Copy Markdown
Contributor

ParoTheParrot commented Sep 12, 2022

good enough. Thanks for the quick reply!
Kepp up the good work with FreshRSS!

@wolfpld wolfpld mentioned this pull request Sep 27, 2022
Closed
@Alkarex Alkarex mentioned this pull request Oct 2, 2022
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Frenzie Frenzie Frenzie approved these changes

Assignees

No one assigned

Labels

UI 🎨 User Interfaces

Projects

None yet

Milestone

1.20.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Alkarex @ParoTheParrot @Frenzie