fix depending results after changing value of "entry->isRead"#4331
Merged
Alkarex merged 3 commits intoFreshRSS:edgefrom Apr 26, 2022
cn-tools:edge
Merged
fix depending results after changing value of "entry->isRead"#4331Alkarex merged 3 commits intoFreshRSS:edgefrom cn-tools:edge
Alkarex merged 3 commits intoFreshRSS:edgefrom
cn-tools:edge
Conversation
…of hook 'entry_before_insert' if anybody use the hook 'entry_before_insert' and change the value of the property 'entry->isRead', the depending results are correct now. In my case my config let all new entrys as "isRead=FALSE" as i will. A new extension which is in progress, can/should/must change the value of this property, but the depending results of this property are wrong before this fix.
Alkarex
reviewed
Apr 25, 2022
Member
|
Thanks, looks reasonable (besides my little suggestion) |
Co-authored-by: Alexandre Alapetite <[email protected]>
Contributor
Author
|
Thanks! And i think you are right with your suggestion, so i merged it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Pull request checklist: