Skip to content

Fix lazyimg single quotes#4330

Merged
Alkarex merged 1 commit intoFreshRSS:edgefrom
Alkarex:lazyimg-apos
Apr 26, 2022
Merged

Fix lazyimg single quotes#4330
Alkarex merged 1 commit intoFreshRSS:edgefrom
Alkarex:lazyimg-apos

Conversation

@Alkarex
Copy link
Copy Markdown
Member

@Alkarex Alkarex commented Apr 25, 2022

Little bug for cases with single quote in URL such as

<img src="123?format='jpg'" />

Could probably be replaced by loading="lazy" in the future, and with a better DOM-aware method, for instance during SimplePie add_attributes()

Little bug for cases with single quote in URL such as

```html
<img src="123?format='jpg'" />
```

Could probably be replaced by `loading="lazy"` in the future, and with a better DOM-aware method, for instance during SimplePie `add_attributes()`
@Alkarex Alkarex added this to the 1.20.0 milestone Apr 25, 2022
@Alkarex
Copy link
Copy Markdown
Member Author

Alkarex commented Apr 26, 2022

Merging because we have a brand new user who is about to try FreshRSS and has a source, which requires this fix :-)

@Alkarex Alkarex merged commit 0b86e34 into FreshRSS:edge Apr 26, 2022
@Alkarex Alkarex deleted the lazyimg-apos branch April 26, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant