Skip to content

Fix: article footer + improve: labeling#4306

Merged
Alkarex merged 18 commits intoFreshRSS:edgefrom
math-GH:fix-article-footer
Apr 18, 2022
Merged

Fix: article footer + improve: labeling#4306
Alkarex merged 18 commits intoFreshRSS:edgefrom
math-GH:fix-article-footer

Conversation

@math-GH
Copy link
Copy Markdown
Contributor

@math-GH math-GH commented Apr 4, 2022

Before:

grafik

grafik

After:

(1), (2), (3): the icon is now clickable. It opens the dropdown menu
(3): new icon. (before: UTF8 icon, after: SVG icon)
(4): headline plus manage button added
(4): new label: UX improved. Button added. Adding by press Enter. Checkbox invisible
grafik

grafik

Changes proposed in this pull request:

  • Javascript + CSS
  • new icon

How to test the feature manually:

  1. go to footer of article
  2. open "sharing" while clicking on the icon
  3. open "article tags" while clicking on the icon
  4. open "My labels" while clicking on the icon
  5. add a new label by pressing enter
  6. add a new label by pressing the button
  7. click the manage button to go to label management

Pull request checklist:

  • clear commit messages
  • code manually tested

@math-GH math-GH added the UI 🎨 User Interfaces label Apr 4, 2022
@math-GH math-GH added this to the 1.20.0 milestone Apr 4, 2022
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Apr 11, 2022 •
edited
Loading

Sorry for the delay. Looks great 👍🏻
Minor detail: on some themes, the add button's layout is a bit strange. For instance:

On "Pafat", a bit too close to the scrollbar
image

On "Mapco" + "Ansum", colour problems?
image

@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Apr 18, 2022

@Alkarex Thanks. I fixed it.

Ready for more reviews

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Apr 18, 2022

Looks good 👍🏻

Not from that PR, but I have just noticed an extra padding-left in the tags for e.g. Mapco:
image

@Alkarex Alkarex merged commit c9d0d20 into FreshRSS:edge Apr 18, 2022
@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Apr 18, 2022

Not from that PR, but I have just noticed an extra padding-left in the tags for e.g. Mapco

The article tags will be changed with #4101

@math-GH math-GH deleted the fix-article-footer branch April 18, 2022 20:24
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Apr 18, 2022

The article tags will be changed with #4101

I have just tried and it does not seem to make any difference

@math-GH
Copy link
Copy Markdown
Contributor Author

math-GH commented Apr 19, 2022

The article tags will be changed with #4101

I have just tried and it does not seem to make any difference

upps, you are right. The tag list is still available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

UI 🎨 User Interfaces

Projects

None yet

Milestone

1.20.0

Development

Successfully merging this pull request may close these issues.

2 participants

@math-GH @Alkarex