Merged
Conversation
Alkarex
reviewed
Apr 20, 2023
| <a href="<?= _url('stats', 'repartition', 'id', $this->feed->id()) ?>"><?= _i('stats') ?> <?= _t('sub.feed.stats') ?></a> | ||
| </div> | ||
|
|
||
| <p><?= sanitizeHTML($this->feed->description()) ?></p> |
Contributor
Author
There was a problem hiding this comment.
It was supposed to. See number 4:
deleted: the feed description. It is editable some centimeters below. It does not make sense to display redundant information.
Member
There was a problem hiding this comment.
It's not redundant fwiw; the one is plain text input and the removed one is HTML.
Contributor
Author
There was a problem hiding this comment.
Here a screen shot of FreshRSS 1.19.0.
What is the benefit to see the description in (1), while it is written in (2) too?
Member
There was a problem hiding this comment.
Just for the record here as well: the (1) is in HTML, meaning that it can contain hyperlinks, images, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After:
In mobile view it looks also much better
Changes proposed in this pull request:
How to test the feature manually:
Pull request checklist: