New sharing service: Web sharing API#4271
Merged
Alkarex merged 20 commits intoFreshRSS:edgefrom Mar 16, 2022
Merged
Conversation
Frenzie
reviewed
Mar 14, 2022
app/i18n/en/gen.php
Outdated
| 'wallabagv2' => 'wallabag v2', | ||
| 'whatsapp' => 'Whatsapp', // TODO | ||
| 'xing' => 'Xing', // TODO | ||
| 'web-sharing-api' => 'Default System Sharing', |
Member
There was a problem hiding this comment.
Suggested change
| 'web-sharing-api' => 'Default System Sharing', | |
| 'web-sharing-api' => 'Default system sharing', |
But maybe something like?
Suggested change
| 'web-sharing-api' => 'Default System Sharing', | |
| 'web-sharing-api' => 'Share through system', |
Contributor
Author
There was a problem hiding this comment.
Share through system does not make me more happier.
Member
There was a problem hiding this comment.
I cannot find anything much better. I have proposed "Standard share" for the French version
Frenzie
reviewed
Mar 14, 2022
Frenzie
approved these changes
Mar 15, 2022
Member
Frenzie
left a comment
Frenzie
left a comment
There was a problem hiding this comment.
Agree to disagree, I suppose. ;-)
Frenzie
reviewed
Mar 15, 2022
app/i18n/en/gen.php
Outdated
| 'wallabagv2' => 'wallabag v2', | ||
| 'whatsapp' => 'Whatsapp', // TODO | ||
| 'xing' => 'Xing', // TODO | ||
| 'web-sharing-api' => 'Default system sharing', |
Member
There was a problem hiding this comment.
Another possibility could be something like:
Suggested change
| 'web-sharing-api' => 'Default system sharing', | |
| 'web-sharing-api' => 'Built-in sharing', |
Alkarex
reviewed
Mar 16, 2022
Co-authored-by: Alexandre Alapetite <[email protected]>
Alkarex
reviewed
Mar 24, 2022
| if (!navigator.share) { | ||
| // https://developer.mozilla.org/en-US/docs/Web/API/Navigator/share | ||
| // do not show the menu entry if browser does not support navigator.share | ||
| document.styleSheets[0].insertRule( |
Member
There was a problem hiding this comment.
Ah, I overlooked that this might not work until enough of the DOM is loaded, otherwise errors sometimes happen depending on the exact orders
I believe this code should be moved to a function called by init_afterDOM().
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Apr 18, 2022
#fix FreshRSS#4271 (comment) Moved to after `DOMContentLoaded`
Alkarex
added a commit
that referenced
this pull request
Apr 19, 2022
#fix #4271 (comment) Moved to after `DOMContentLoaded`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
HTMLtagoption for the sharing services (optional) to allowbuttonas list item type that is not a linkHow to test the feature manually:
Default Sharing Servicein Sharing optionImportant information: The menu item in share menu is not available, if you browser does not support it (f.e. Firefox on Windows)
Example on Chromium on Windows 10: (1) the title of the shared article + (2) the shared link
Pull request checklist: